add hazard=* tag for highways#1776
Conversation
I don't see anything about |
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
|
@aaei924 the examples at https://wiki.openstreetmap.org/wiki/Proposal:Hazard#Examples all show a combination of tags … but different tags. Mostly Another thing I wonder is, that https://wiki.openstreetmap.org/wiki/Key:hazard#Traffic_hazards does not promote tagging the road way too much. Tagging the traffic sign itself is mentioned instead. And TBH, I wonder why we would want to promote tagging the road way given that those signs are super hard to tag on a way: The have a start but usually not an "end" sign, so one has to come up with a length without being able to verify it. And once we split the road, the sign is copied which would suggest a new So personally I am not convinced we would want those tags to be promoted on ways. Rather having more |
|
On a technical note, there are some highway classes missing like |
|
At least in the Americas, warning signs of all sorts can come with “Next X Miles” or “Next X km” plaques. To the contrary, I couldn’t imagine tagging |
matkoniecz
left a comment
There was a problem hiding this comment.
this should be clearly about signed hazards, as https://wiki.openstreetmap.org/wiki/Key:hazard mentions
not about subjective rating
if actual tagging degenerated into subjective ratings it must not be promoted by iD
Co-authored-by: Tobias <t@tobiasjordans.de>
This tag on highway is seemed to have been intended to use with Many hazard signs even don't have any explicit end sign, but in some cases, for example, most of |
|
Even if a warning sign doesn’t come with an explicit distance, it often still has a natural start and end because the same sign is posted as you approach from either direction. (This only applies to two-way roads, of course.) I think users would be able to figure that out themselves, but if not, the help text from the data item could suggest the right method. |
There was a problem hiding this comment.
Descriptions at https://wiki.openstreetmap.org/wiki/Tag:hazard=dangerous_junction and other tag pages should also be fixed
right now it looks like permitting 100% subjective tagging
while https://wiki.openstreetmap.org/wiki/Key:hazard is clear that it is about signed hazards on roadways
This comment was marked as resolved.
This comment was marked as resolved.
@matkoniecz I've just edited that wiki page. I clarified that the tag is only used when there's a traffic sign. |
There was a problem hiding this comment.
note "and other tag pages should also be fixed"
I checked random one - https://wiki.openstreetmap.org/wiki/Tag%3Ahazard%3Dchildren and it is also missing info that it is valid only for signed hazards
other value pages also should be fixed
|
Is anyone planning to fix documentation? |
I changed all documents of approved values at traffic hazards. It's good to proceed. |
hazard=* tag for highways
Description, Motivation & Context
By this field, iD editor allows people to map
hazard=*key on highway features easily.hazard=*is for boundary and highway, but currently iD tagging schema supportshazardkey only for boundary. This PR addshazardkey support also for highways. This single key has been divided intohazard_boundary.jsonandhazard_highway.jsonfiles, because the key has different values depending on features.This tag has been approved by proposal procedure.
Related issues
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.