Skip to content

remove implicit inheritance for shop=trade#1814

Merged
tyrasd merged 3 commits intomainfrom
matkoniecz-patch-2
Dec 9, 2025
Merged

remove implicit inheritance for shop=trade#1814
tyrasd merged 3 commits intomainfrom
matkoniecz-patch-2

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

see #1813 and ideditor/schema-builder#204 (comment)

Description, Motivation & Context

see #1813

Related issues

related to #1813

Links and data

Relevant OSM Wiki links:

none

Relevant tag usage stats:

none

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz

This comment was marked as off-topic.

This comment was marked as off-topic.

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

tested on brand field that inheritance works

@tyrasd tyrasd added the waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback. label Nov 25, 2025
Copy link
Copy Markdown
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's wait a couple of days so that others have a little more time to comment their opinion either here or on #1813 / ideditor/schema-builder#204.

@tyrasd tyrasd added schema and removed waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback. schema labels Dec 9, 2025
@tyrasd tyrasd merged commit 3de6a4c into main Dec 9, 2025
8 checks passed
@matkoniecz
Copy link
Copy Markdown
Collaborator Author

@matkoniecz matkoniecz deleted the matkoniecz-patch-2 branch December 9, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants