Skip to content

Add search terms to shop=esoteric#1830

Merged
tordans merged 1 commit intomainfrom
matkoniecz-patch-7
Dec 14, 2025
Merged

Add search terms to shop=esoteric#1830
tordans merged 1 commit intomainfrom
matkoniecz-patch-7

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

from https://github.com/SomeoneElseOSM/SomeoneElse-style/blob/master/shared_lua.lua#L2453

Description, Motivation & Context

Related issues

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

screen-2025-11-27-12-47-26 screen-2025-11-27-12-47-50 screen-2025-11-27-12-48-08 screen-2025-11-27-12-48-26 screen-2025-11-27-12-48-41 screen-2025-11-27-12-49-12

@matkoniecz matkoniecz marked this pull request as ready for review November 27, 2025 12:58
@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Dec 6, 2025

@matkoniecz I am having trouble getting the motivation and context for this. So just for documentation, could you describe this a bit? The LUA link does not help and the screenshots are likely a "before" to show some mess?

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

My motivation is to make this preset findable by additional likely search terms.

@tordans tordans changed the title more woo terms Add search terms to shop=esoteric Dec 14, 2025
@tordans tordans added the field label Dec 14, 2025
@tordans tordans merged commit f6c6c31 into main Dec 14, 2025
8 checks passed
@tordans tordans deleted the matkoniecz-patch-7 branch December 14, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants