Add some new terms to make finding preset entries easier.#1888
Add some new terms to make finding preset entries easier.#1888tyrasd merged 4 commits intoopenstreetmap:mainfrom
Conversation
Terms were suggested by LLM and human-reviewed (around 90% of suggestions were discarded for various reasons).
|
@ZeLonewolf I consulted some terms from people from USA, but not in OSM context. Maybe you can spot some pointless/bad changes? Or what else can be changed. |
|
mote: some are UKish, but seem to be popular enough (especially among nonative speakers) to be worth including |
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
|
and for variants not included, but considered: for example |
| ], | ||
| "terms": [ | ||
| "manicure", | ||
| "nails", |
There was a problem hiding this comment.
nail was finding it, nails not
in this case it seems reasonable to add it as adding it as a single word seems likely
|
project has translation from US English to UK English so maybe parcel and spectacles should be dropped. Though may be worth keeping for non natives specs were mentioned as shortening of spectacles |
…lly by nonnative speaker
| "amenity": "car_rental" | ||
| }, | ||
| "terms": [ | ||
| "hire", |
There was a problem hiding this comment.
I think the usual term in the UK is "car hire"
There was a problem hiding this comment.
as general term yes, but I think it can be reasonably listed if someone typed just "hire"
|
I added a couple comments. There's a few that were weird but not wrong, otherwise seems fine as alternate search terms. |
Terms were suggested by LLM and human-reviewed (around 90% of suggestions were discarded for various reasons).
Description, Motivation & Context
intended to make finding proper preset terms easier, also I was playing with LLMs to which degree they can be useful
Related issues
none
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
not relevant here
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.