Skip to content

Add some new terms to make finding preset entries easier.#1888

Merged
tyrasd merged 4 commits intoopenstreetmap:mainfrom
matkoniecz:terms
Jan 13, 2026
Merged

Add some new terms to make finding preset entries easier.#1888
tyrasd merged 4 commits intoopenstreetmap:mainfrom
matkoniecz:terms

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

Terms were suggested by LLM and human-reviewed (around 90% of suggestions were discarded for various reasons).

Description, Motivation & Context

intended to make finding proper preset terms easier, also I was playing with LLMs to which degree they can be useful

Related issues

none

Links and data

Relevant OSM Wiki links:

  • none

Relevant tag usage stats:

not relevant here

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Terms were suggested by LLM and human-reviewed (around 90% of suggestions were discarded for various reasons).
@matkoniecz
Copy link
Copy Markdown
Collaborator Author

@ZeLonewolf I consulted some terms from people from USA, but not in OSM context.

Maybe you can spot some pointless/bad changes? Or what else can be changed.

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

mote: some are UKish, but seem to be popular enough (especially among nonative speakers) to be worth including

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

and for variants not included, but considered: for example creche

],
"terms": [
"manicure",
"nails",
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nail was finding it, nails not

in this case it seems reasonable to add it as adding it as a single word seems likely

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

project has translation from US English to UK English so maybe parcel and spectacles should be dropped. Though may be worth keeping for non natives

specs were mentioned as shortening of spectacles

"amenity": "car_rental"
},
"terms": [
"hire",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the usual term in the UK is "car hire"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as general term yes, but I think it can be reasonably listed if someone typed just "hire"

Comment thread data/presets/highway/cycleway.json
@ZeLonewolf
Copy link
Copy Markdown
Contributor

I added a couple comments. There's a few that were weird but not wrong, otherwise seems fine as alternate search terms.

@tyrasd tyrasd added new-label changes the name, aliases or terms of a preset search-related labels Jan 13, 2026
@tyrasd tyrasd merged commit 03e13b2 into openstreetmap:main Jan 13, 2026
5 checks passed
@matkoniecz matkoniecz deleted the terms branch January 13, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-label changes the name, aliases or terms of a preset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants