Fix Roentgen icon naming mismatch for radio telescope#1920
Merged
tordans merged 1 commit intoopenstreetmap:mainfrom Feb 1, 2026
Merged
Fix Roentgen icon naming mismatch for radio telescope#1920tordans merged 1 commit intoopenstreetmap:mainfrom
tordans merged 1 commit intoopenstreetmap:mainfrom
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
tordans
approved these changes
Feb 1, 2026
Collaborator
tordans
left a comment
tordans
left a comment
There was a problem hiding this comment.
Just waiting on #1919 (comment) to maybe get more context but based on bryceco issue this should be good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1919
This PR fixes a naming mismatch in the radio.json preset. The icon was incorrectly defined with a hyphen (roentgen-telescope-radio), which prevented the icon from loading in editors.
Changes :
Changed the icon ID from roentgen-telescope-radio to roentgen-telescope_radio.
I also verified all other Roentgen icon references in the presets using grep. It appears that roentgen-telescope-radio is the only one using a hyphen. All other multi-word Roentgen icons correctly use underscores.