Add localized "others" string to common multicombo fields #1924
Add localized "others" string to common multicombo fields #1924dheeraj12347 wants to merge 2 commits intoopenstreetmap:mainfrom
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
| "caseSensitive": true, | ||
| "strings": { | ||
| "options": { | ||
| "others": "Others", |
There was a problem hiding this comment.
is it an established and welcome tagging?
There was a problem hiding this comment.
from #1860 it seems that it should be possible to set only "no" here, if I read it correctly
is other tagging making sense in this value?
There was a problem hiding this comment.
payment:others=yes is also documented to mean that some other payment methods are accepted, but currency:others=yes is discouraged for meaning that all other currencies are accepted. I have a feeling the latter is someone’s uninformed opinion about what this tag is actually used for. After all, it could be useful to indicate whether or not the tags are complete. There are 1,055 occurrences of *:others=yes, so not exactly a typo. This will probably need a forum thread to sort out…
|
for start: is this PR a case of LLM generated PR? build process:
comment above:
|
|
Thanks for the review. |
|
I’ve updated this PR to limit it to the established cases: language_multi: add localized others in strings.options. payment_multi: add localized others in strings.options, consistent with the documented payment:others=yes usage. I removed the others additions from currency_multi and recycling_accepts in this PR so that any changes to those tags can be discussed more broadly first. This PR is now only about making existing, well‑understood others values localizable and displayed as chips. |
|
Can you follow
? |
This PR implements the localized others string for several well-established multicombo fields, as discussed in #1860.
Following the suggestion from @1ec5, I have added others to the strings.options block for the following fields:
currency_multi.json
language_multi.json
payment_multi.json
recycling_accepts.json
This ensures the others value appears as a localized "blue chip" in the editor UI rather than raw text.
Fixes #1860