Skip to content

Add localized "others" string to common multicombo fields #1924

Open
dheeraj12347 wants to merge 2 commits intoopenstreetmap:mainfrom
dheeraj12347:fix-localized-others-string-v2
Open

Add localized "others" string to common multicombo fields #1924
dheeraj12347 wants to merge 2 commits intoopenstreetmap:mainfrom
dheeraj12347:fix-localized-others-string-v2

Conversation

@dheeraj12347
Copy link
Copy Markdown

This PR implements the localized others string for several well-established multicombo fields, as discussed in #1860.

Following the suggestion from @1ec5, I have added others to the strings.options block for the following fields:

currency_multi.json

language_multi.json

payment_multi.json

recycling_accepts.json

This ensures the others value appears as a localized "blue chip" in the editor UI rather than raw text.

Fixes #1860

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2026

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

Comment thread data/fields/recycling_accepts.json Outdated
"caseSensitive": true,
"strings": {
"options": {
"others": "Others",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it an established and welcome tagging?

Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from #1860 it seems that it should be possible to set only "no" here, if I read it correctly

is other tagging making sense in this value?

Copy link
Copy Markdown
Contributor

@1ec5 1ec5 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

payment:others=yes is also documented to mean that some other payment methods are accepted, but currency:others=yes is discouraged for meaning that all other currencies are accepted. I have a feeling the latter is someone’s uninformed opinion about what this tag is actually used for. After all, it could be useful to indicate whether or not the tags are complete. There are 1,055 occurrences of *:others=yes, so not exactly a typo. This will probably need a forum thread to sort out…

@matkoniecz
Copy link
Copy Markdown
Collaborator

for start: is this PR a case of LLM generated PR?

build process:

[warn] Code style issues found in 4 files. Run Prettier with --write to fix.

comment above:

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

@dheeraj12347
Copy link
Copy Markdown
Author

Thanks for the review.
This PR is not generated by an LLM. I implemented the changes myself based on the discussion in #1860 and 1ec5’s suggestion to move others into the strings.options block so it can be localized and shown as a chip in the UI. I’m happy to adjust anything that doesn’t match the project’s expectations.

@dheeraj12347
Copy link
Copy Markdown
Author

I’ve updated this PR to limit it to the established cases:

language_multi: add localized others in strings.options.

payment_multi: add localized others in strings.options, consistent with the documented payment:others=yes usage.

I removed the others additions from currency_multi and recycling_accepts in this PR so that any changes to those tags can be discussed more broadly first. This PR is now only about making existing, well‑understood others values localizable and displayed as chips.

@matkoniecz
Copy link
Copy Markdown
Collaborator

Can you follow

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-value adds value(s) to existing field

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multicombo fields should specify "others" as a localizable string

4 participants