Replace misleading icon for tourism=viewpoint with new temaki-viewpoint

[ak8abhinay]

Description:

Replaces temaki-spotting_scope with the newly added temaki-viewpoint icon for the tourism=viewpoint preset.

The current icon (spotting_scope) was misleading for tourism=viewpoint, it looked more like amenity=binoculars than a viewpoint, as raised in the issue.
Since there was no proper viewpoint icon available in Temaki, I took a raw SVG from the Osmic icon library, tried to understand how Temaki icons are structured, modified the SVG to match it, and raised a PR to get it merged into the Temaki repo first PR#102-viewpoint.svg. Once that got merged I came here to make this change.
So, first getting viewpoint.svg into Temaki, and now using it here to replace the misleading icon in id-tagging-schema.

Fixes #1914

[github-actions]

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

[matkoniecz]

@ak8abhinay can you do

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

? With posting screenshot whether new icon works as expected?

[ak8abhinay]

can you do

Yes, sure @matkoniecz.

But, Temaki v5.12.0 was released yesterday and includes the viewpoint icon. The iD editor's package.json is currently using @rapideditor/temaki ^5.11.0 so the icon shows blank. I will add the documentation as soon as it updates to v5.12.0.

[matkoniecz]

openstreetmap/iD#11953 appeared (not merged yet)

[matkoniecz]

will close/reopen to trigger build with now merged dependency

[matkoniecz]

works!

[matkoniecz]

Thanks for the PR! It is now merged but note that before you will see it in iD few things need to happen.

iD tagging schema needs to get release (see https://github.com/openstreetmap/id-tagging-schema/releases - latest one mentioned there is just a draft). And later needs to be pulled in by iD.

Thanks again for your contribution! If you are interested in making other one it would be really welcome!