Adding "sport" field for leisure=bowling_alley (#1973)

[petercooperjr]

Description, Motivation & Context

While many people will think of a specific sport when hearing "bowling", exactly what that sport is can depend on the part of world one is in. Different kinds of bowling are popular in different places, and some bowling alleys even offer multiple types of bowling. The "sport" tag has been documented on the leisure=bowling_alley wiki page for quite some time as being used to describe which form of bowling a given bowling alley offers. (Note, I recently updated the wiki page to include some more types of bowling, and make explicit that multiple values can be included via semicolons, but such values were certainly already in use.)

But I found it odd that when adding (or editing) a bowling alley in iD, that there isn't a field given in the preset for specifying the sport. I think that there should be, with options for the most popular types (such as 10pin) easy to select.

Related issues

#1973

Links and data

Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dbowling_alley

Relevant tag usage stats:

From taginfo, values for sport=
10pin 2 595
9pin 1 398
candlepin 14
9pin;10pin 12
10pin;9pin 10
5pin 8
duckpin 3

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

1. After you submit your PR, the system will create a preview and comment on your PR:

   🍱 Your pull request preview is ready.
   If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

2. Once the preview is ready, use it to test your changes.

3. Now copy the snippet below into a new comment and fill out the blanks.

4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

[github-actions]

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

[matkoniecz]

thanks for the PR and including explanation!

---

Sadly I lack knowledge to judge it, and wiki was just edited ( https://wiki.openstreetmap.org/w/index.php?title=Tag:leisure%3Dbowling_alley&diff=prev&oldid=2958489 ) so it cannot be treated as an independent confirmation

(but thanks for edit! It is just that it cannot be treated as independent confirmation, the same happens quite often to me!)

Maybe one of other people actively reviewing PRs knows something more on this topic and is familiar with tagging in this area?

[matkoniecz]

Alternative would be to ask on community forums for people to check it, but it may end just being stuck like #1653 was

[petercooperjr]

So I did edit the wiki to add a few more sport options, but I think the PR can be judged based on the prior wiki version if that helps. I added 5pin and duckpin to the wiki based on what seemed to exist in taginfo but if there are better options for those I'd be happy to change them. The five bowling types that I listed (both in the wiki, and in this PR) are based on what's listed at the top of the Wikipedia article for Bowling, "For specific types of bowling, see Tenpin bowling, Duckpin bowling, Candlepin bowling, Nine-pin bowling, and Five-pin bowling."

I know that duckpin, candlepin, and 5-pin aren't as popular as 9-pin and 10-pin, but that's also why I thought it would be helpful to make it easier for people to be able to map them.

Thank you!

[petercooperjr]

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1974--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=19.00/42.68951/-73.85041&disable_features=boundaries&background=none&id=n721629807

Search

No changes to search for bowling alley.

Info-i

The sport field has the existing info and link to wiki.

Wording

• American English
• name, aliases (if present) use Title Case
• terms (if present) use lower case, sorted A-Z

Though I'm hoping "10pin", "5pin", "9pin" is the correct sort, since 1 comes before 5 even though most people would count 10 as coming after 9.

[tyrasd]

In general, this looks OK to me. Yes, some of the added variants are not yet tagged at a significant number, but they do all have wikipedia pages, so I think it does make sense to include them.

I found the tag sport=8pin on the wiki. Was that omitted on purpose?

FWIW, it seems like also some non-bowling sports are apparently tagged on leisure=bowling_alley, e.g. sport=darts. I'm not sure how to best address those "secondary" sport tags. 🤔

[tyrasd]

I'd say that the options here should be rather sorted by how common the respective variants are, i.e. the most common ones on top, the rarer ones below.

[petercooperjr]

I found the tag sport=8pin on the wiki. Was that omitted on purpose?

No, I was mainly going by what Wikipedia listed as Bowling variants under "pin bowling", but it wouldn't shock me if the English Wikipedia was a bit North America centric and other bowling versions were also out there that should be added.

It's also not clear to me if "sport=9pin" may actually mean a rather different game in America vs. Europe based on Wiki's 9-pin description as well, but I wasn't trying to redefine any tags or anything, just trying to document what currently exists and see if iD could encourage people to use the sport field as well. There's some variation within each sport as well: Duckpin has "rubber band" and "mini" versions, and 5-pin has "free-fall" and "string-set" versions. But I'm not aware of any standard for tagging those yet, and I think lumping them all into the same "sport" is probably as good a plan as any for now.

I'd say that the options here should be rather sorted by how common the respective variants are, i.e. the most common ones on top, the rarer ones below.

Ah, I was just trying to sort alphabetically since I was unfamiliar with how this is all actually used under the hood. I certainly have no objection to trying to sort by some reasonable measure of popularity. My first thought is that most-popular to least-popular is 10pin, 9pin, 5pin, duckpin, candlepin. But that's based on my intuition, not any numbers, so I'll see if I can dig some real data up at some point. I'm not sure current OSM data is an especially good ranking outside of 10-pin and 9-pin, since the sport tag for bowling alleys (and bowling alleys in general) are undermapped (which is part of what I'm hoping to improve by submitting this PR) especially for the more regional and less common variants.

Just as another reference point, the bottom of the Candlepin Bowling Wikipedia article links to a Google user map that someone put together showing non-10-pin bowling centers in North America, which may help give a sense of what's regionally popular where (at least according to whomever put together that map).

[petercooperjr]

It looks like sport=8pin is usually used with leisure=pitch, not with leisure=bowling_alley. I think it may be an outdoor game, not one played in a "bowling alley".

[petercooperjr]

So, just from one random site I found that listed North American bowling centers:

Type	Number of locations
10-pin	5560
5-pin	404
Duckpin	191
Candlepin	143

Given that there's over a thousand sport=9pin in OSM already (and it's more popular in Europe whereas the numbers above were just North America), I think my intuition of the ordering being 10pin, 9pin, 5pin, duckpin, candlepin is reasonable. I could try to get more hard numbers from somewhere if just looking at the first source I could find isn't sufficient.

[matkoniecz]

https://taginfo.openstreetmap.org/tags/sport=10pin - decent usage, has wiki page at https://wiki.openstreetmap.org/wiki/Tag:sport=10pin

https://taginfo.openstreetmap.org/tags/sport=9pin - decent usage, has wiki page at https://wiki.openstreetmap.org/wiki/Tag:sport=9pin

https://taginfo.openstreetmap.org/tags/sport=5pin - just 8 uses, https://wiki.openstreetmap.org/wiki/Tag:sport=5pin exists - and we should list to avoid people tagging wrong one which may happen if we would include just two popular ones. Which is likely worse and bigger danger than typos

https://taginfo.openstreetmap.org/tags/sport=duckpin - https://wiki.openstreetmap.org/wiki/Tag:sport=duckpin - comment as above

https://taginfo.openstreetmap.org/tags/sport=candlepin#overview - https://wiki.openstreetmap.org/wiki/Tag:sport=candlepin

all options appear in selector

[matkoniecz]

Thanks for the PR! It is now merged but note that before you will see it in iD few things need to happen.

iD tagging schema needs to get release (see https://github.com/openstreetmap/id-tagging-schema/releases - latest one mentioned there is just a draft). And later needs to be pulled in by iD.

Thanks again for your contribution! If you are interested in making other one it would be really welcome!