Skip to content

Add indoor_seating field as yes/no boolean, add seating fields to bakeries as moreFields#1984

Merged
matkoniecz merged 6 commits intoopenstreetmap:mainfrom
codeinabox:indoor_seating
Apr 19, 2026
Merged

Add indoor_seating field as yes/no boolean, add seating fields to bakeries as moreFields#1984
matkoniecz merged 6 commits intoopenstreetmap:mainfrom
codeinabox:indoor_seating

Conversation

@codeinabox
Copy link
Copy Markdown
Contributor

@codeinabox codeinabox commented Mar 4, 2026

Description, Motivation & Context

The app StreetComplete has a seating quest that populates the indoor_seating field. This adds the field to the id tagging scheme.

Links and data

Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Key:indoor_seating

Relevant tag usage stats:

Value Count
yes 17,3836
no 18,326
bar_table 212

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2026

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@codeinabox codeinabox marked this pull request as ready for review March 4, 2026 11:07
@codeinabox
Copy link
Copy Markdown
Contributor Author

I'm wondering if it's better to treat indoor seating as a checkbox like StreetComplete does, or have the combo including bar_table.

@matkoniecz
Copy link
Copy Markdown
Collaborator

I have mixed feeling about bar_table

on one hand documented on wiki, has point...

on the other hand basically no uses anyway

screen-2026-03-06-20-15-35 screen-2026-03-06-20-15-19

@codeinabox
Copy link
Copy Markdown
Contributor Author

have mixed feeling about bar_table

I agree. I've switched it back to a checkbox so it behaves like outdoor_seating, which in theory also should be a combo according to the wiki but is simply treated as a checkbox.

@matkoniecz matkoniecz added the new-field create a new field (see add-field for cases where field from presets is added to new entries) label Mar 10, 2026
@codeinabox
Copy link
Copy Markdown
Contributor Author

@matkoniecz what are your thoughts of adding this field as a checkbox?

@matkoniecz
Copy link
Copy Markdown
Collaborator

matkoniecz commented Mar 11, 2026

I would tend toward treating it as yes/no checkbox field.

screen-2026-03-11-12-10-57

@codeinabox
Copy link
Copy Markdown
Contributor Author

I would tend toward treating it as yes/no checkbox field.

Thank you for confirming. The field is a checkbox so this is ready for review.

@matkoniecz matkoniecz changed the title Add indoor_seating field Add indoor_seating field as yes/no boolean Mar 14, 2026
Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR makes sense in the current form

mentioned at https://community.openstreetmap.org/t/likely-upcoming-tags-in-id-review-welcome-food-old-name-piercing-indoor-seating-yes-no/142495

I propose to wait at least until 2026-04-04 to give community time to review this PR

@codeinabox
Copy link
Copy Markdown
Contributor Author

@matkoniecz could this now be merged in, or are you still awaiting feedback?

"fhrs/id-GB"
"fhrs/id-GB",
"indoor_seating",
"outdoor_seating"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you amend commit description and PR title to note that bakery gets also outdoor_seating ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do it also myself if you are not protesting

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that would be very kind.

@matkoniecz matkoniecz changed the title Add indoor_seating field as yes/no boolean Add indoor_seating field as yes/no boolean, add seating fields to bakeries as moreFields Apr 19, 2026
@matkoniecz matkoniecz merged commit 2d474e3 into openstreetmap:main Apr 19, 2026
5 checks passed
@matkoniecz
Copy link
Copy Markdown
Collaborator

matkoniecz commented Apr 19, 2026

Thanks for the PR! It is now merged but note that before you will see it in iD few things need to happen.

iD tagging schema needs to get release (see https://github.com/openstreetmap/id-tagging-schema/releases - latest one mentioned there is just a draft). And later needs to be pulled in by iD.

Thanks again for your contribution! If you are interested in making other one it would be really welcome! If you are looking for some easy and useful task look here.

@codeinabox codeinabox deleted the indoor_seating branch April 19, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-field create a new field (see add-field for cases where field from presets is added to new entries)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants