Add indoor_seating field as yes/no boolean, add seating fields to bakeries as moreFields#1984
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
|
I'm wondering if it's better to treat indoor seating as a checkbox like StreetComplete does, or have the combo including |
421fa9f to
a55bc67
Compare
I agree. I've switched it back to a checkbox so it behaves like |
|
@matkoniecz what are your thoughts of adding this field as a checkbox? |
Thank you for confirming. The field is a checkbox so this is ready for review. |
indoor_seating field as yes/no boolean
|
@matkoniecz could this now be merged in, or are you still awaiting feedback? |
| "fhrs/id-GB" | ||
| "fhrs/id-GB", | ||
| "indoor_seating", | ||
| "outdoor_seating" |
There was a problem hiding this comment.
can you amend commit description and PR title to note that bakery gets also outdoor_seating ?
There was a problem hiding this comment.
I can do it also myself if you are not protesting
There was a problem hiding this comment.
Thank you, that would be very kind.
indoor_seating field as yes/no booleanindoor_seating field as yes/no boolean, add seating fields to bakeries as moreFields
|
Thanks for the PR! It is now merged but note that before you will see it in iD few things need to happen. iD tagging schema needs to get release (see https://github.com/openstreetmap/id-tagging-schema/releases - latest one mentioned there is just a draft). And later needs to be pulled in by iD. Thanks again for your contribution! If you are interested in making other one it would be really welcome! If you are looking for some easy and useful task look here. |



Description, Motivation & Context
The app StreetComplete has a seating quest that populates the
indoor_seatingfield. This adds the field to the id tagging scheme.Links and data
Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Key:indoor_seating
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.