migrate 48 fields to type=measurement #1988
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,15 @@ | ||
| { | ||
| "key": "aerialway:duration", | ||
| "type": "measurement", | ||
| "measurement": { | ||
| "dimension": "duration", | ||
| "usage": "default", | ||
| "units": [ | ||
| "minute" | ||
| ], | ||
| "impliedUnit": "minute" | ||
| }, | ||
| "minValue": 0, | ||
| "label": "{duration}", | ||
|
Collaborator
There was a problem hiding this comment. I am not sure whether we want to remove hint are we assuming that iD and other will add it back, somehow, using
Collaborator
There was a problem hiding this comment. but then we have |
||
| "placeholder": "1, 2, 3..." | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,11 @@ | ||
| { | ||
| "key": "capacity", | ||
| "type": "measurement", | ||
| "measurement": { | ||
| "dimension": "volume", | ||
| "usage": "default" | ||
| }, | ||
| "minValue": 0, | ||
| "label": "Capacity", | ||
| "placeholder": "50, 100, 200..." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| { | ||
| "key": "climbing:length", | ||
| "type": "measurement", | ||
| "measurement": { | ||
| "dimension": "length", | ||
| "usage": "default", | ||
| "impliedUnit": "meter" | ||
| }, | ||
| "minValue": 0, | ||
| "label": "Length" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| { | ||
| "key": "depth", | ||
| "minValue": 0, | ||
| "type": "measurement", | ||
| "measurement": { | ||
| "dimension": "length", | ||
| "usage": "default", | ||
| "impliedUnit": "meter" | ||
| }, | ||
| "label": "Depth" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,14 @@ | ||
| { | ||
| "key": "distance", | ||
| "type": "measurement", | ||
| "label": "Distance", | ||
| "terms": [ | ||
| "length", | ||
| "mileage" | ||
| ], | ||
| "measurement": { | ||
| "dimension": "length", | ||
| "usage": "road", | ||
| "impliedUnit": "kilometer" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| { | ||
| "key": "dock:height", | ||
| "minValue": 0, | ||
| "type": "measurement", | ||
| "measurement": { | ||
| "dimension": "length", | ||
| "usage": "default", | ||
| "impliedUnit": "meter" | ||
| }, | ||
| "label": "Dock Height" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| { | ||
| "key": "dock:width", | ||
| "minValue": 0, | ||
| "type": "measurement", | ||
| "measurement": { | ||
| "dimension": "length", | ||
| "usage": "default", | ||
| "impliedUnit": "meter" | ||
| }, | ||
| "label": "Dock Width" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| { | ||
| "key": "door:height", | ||
| "minValue": 0, | ||
| "type": "measurement", | ||
| "measurement": { | ||
| "dimension": "length", | ||
| "usage": "default", | ||
| "impliedUnit": "meter" | ||
| }, | ||
| "label": "Door Height" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| { | ||
| "key": "door:width", | ||
| "minValue": 0, | ||
| "type": "measurement", | ||
| "measurement": { | ||
| "dimension": "length", | ||
| "usage": "default", | ||
| "impliedUnit": "meter" | ||
| }, | ||
| "label": "Door Width" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,16 @@ | ||
| { | ||
| "key": "fire_hydrant:pressure", | ||
| "type": "measurement", | ||
| "measurement": { | ||
| "dimension": "pressure", | ||
| "usage": "default", | ||
| "units": [ | ||
| "bar" | ||
| ], | ||
| "impliedUnit": "bar" | ||
| }, | ||
| "label": "Pressure", | ||
| "autoSuggestions": true, | ||
| "snake_case": false, | ||
| "caseSensitive": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,11 @@ | ||
| { | ||
| "key": "frequency", | ||
| "type": "measurement", | ||
| "label": "Operating Frequency", | ||
| "measurement": { | ||
| "dimension": "frequency", | ||
| "usage": "default", | ||
| "impliedUnit": "hertz" | ||
| }, | ||
| "autoSuggestions": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,15 @@ | ||
| { | ||
| "key": "frequency", | ||
| "type": "measurement", | ||
| "label": "{frequency}", | ||
| "prerequisiteTag": { | ||
| "key": "electrified", | ||
| "valueNot": "no" | ||
| }, | ||
| "measurement": { | ||
| "dimension": "frequency", | ||
| "usage": "default", | ||
| "impliedUnit": "hertz" | ||
| }, | ||
| "autoSuggestions": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,14 @@ | ||
| { | ||
| "key": "gauge", | ||
| "type": "measurement", | ||
| "label": "Gauge", | ||
| "measurement": { | ||
| "dimension": "length", | ||
| "usage": "default", | ||
| "units": [ | ||
| "millimeter" | ||
| ], | ||
| "impliedUnit": "millimeter" | ||
| }, | ||
| "autoSuggestions": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,13 @@ | ||
| { | ||
| "key": "generator:output:electricity", | ||
| "type": "measurement", | ||
| "measurement": { | ||
| "dimension": "power", | ||
| "usage": "default" | ||
| }, | ||
| "label": "Power Output", | ||
| "placeholder": "50 MW, 100 MW, 200 MW...", | ||
| "autoSuggestions": true, | ||
| "snake_case": false, | ||
| "caseSensitive": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| { | ||
| "key": "height", | ||
| "minValue": 0, | ||
| "type": "measurement", | ||
| "measurement": { | ||
| "dimension": "length", | ||
| "usage": "default", | ||
| "impliedUnit": "meter" | ||
| }, | ||
| "label": "Height" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| { | ||
| "key": "height:hub", | ||
| "minValue": 0, | ||
| "type": "measurement", | ||
| "measurement": { | ||
| "dimension": "length", | ||
| "usage": "default", | ||
| "impliedUnit": "meter" | ||
| }, | ||
| "label": "Height of Hub" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| { | ||
| "key": "length", | ||
| "type": "measurement", | ||
| "measurement": { | ||
| "dimension": "length", | ||
| "usage": "default", | ||
| "impliedUnit": "meter" | ||
| }, | ||
| "minValue": 0, | ||
| "label": "Length" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just learned that
railway:positionandrailway:position:exactusemi:12.3instead of12.3 mi😭and that tag uses a "fake" unit called
pkmin argentina. i guess we can't support that field