Add preset for leisure=summer_camp

[ashree2118]

Description, Motivation & Context

Added a preset for leisure=summer_camp to resolve #1481.

Related issues

Closes #1481

Created because the previous pr #1495 attempting to solve this seemed to fail builds and abandoned.

Links and data

Relevant OSM Wiki links:

• …

Relevant tag usage stats:

…

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

1. After you submit your PR, the system will create a preview and comment on your PR:

   🍱 Your pull request preview is ready.
   If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

2. Once the preview is ready, use it to test your changes.

3. Now copy the snippet below into a new comment and fill out the blanks.

4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

[github-actions]

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

[ashree2118]

Test-Documentation

Preview links & Sidebar Screenshots

Test confirming the new leisure=summer_camp preset is available.

1. Summer Camp preset:

Wording

• American English
• name, aliases (if present) use Title Case
• terms (if present) use lower case, sorted A-Z

[matkoniecz]

disclaimer: I am not really familiar with this POI, but based on #1495 (review) and OSM Wiki and cursory check of info on Internet it seems a real and reasonable POI type

I expect it will stay open for a while for review from wider OSM community

opened https://community.openstreetmap.org/t/if-leisure-summer-camp-is-a-terrible-tagging-schema-it-would-be-a-good-moment-to-protest/142098

(but even if tagging scheme is bad, that does not change that PR itself is fine and was based on open issue)

[andrewharvey]

I approve this change.

But I suggest we add seasonal as a field (for example as we do for leisure=ice_rink.

It shouldn't hold up this PR, but it looks like the seasonal field is only a yes/no toggle, ideally it would support all the other values spring/summer/autumn/winter/wet_season/dry_season from https://wiki.openstreetmap.org/wiki/Key:seasonal

Other fields could include:

• operator
• website
• phone

[matkoniecz]

discussion is active at https://community.openstreetmap.org/t/if-leisure-summer-camp-is-a-terrible-tagging-schema-it-would-be-a-good-moment-to-protest/142098/31 so for now I would wait with merge

I posted there that I would recommend waiting with merge here, as long as discussion is active or if there would be attempt to introduce a less confusing tagging schema.

[matkoniecz]

https://community.openstreetmap.org/t/if-leisure-summer-camp-is-a-terrible-tagging-schema-it-would-be-a-good-moment-to-protest/142098/41

EDIT: looks like it will be merged relatively soon

[matkoniecz]

Thanks for the PR! It is now merged but note that before you will see it in iD few things need to happen.

iD tagging schema needs to get release (see https://github.com/openstreetmap/id-tagging-schema/releases - latest one mentioned there is just a draft). And later needs to be pulled in by iD.

Thanks again for your contribution! If you are interested in making other one it would be really welcome!