Use fas-jar icon for honey shop preset#2033
Merged
tyrasd merged 1 commit intoopenstreetmap:mainfrom Mar 13, 2026
Merged
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
Contributor
Author
|
Here is how the icon looking in preview. It is rendering perfectly. 
|
matkoniecz
approved these changes
Mar 12, 2026
Collaborator
|
raised ideditor/schema-builder#271 then (does not block this PR) in case you are interested, #41 (comment) has some other icon ideas (in addition to already created extracted issues) |
tyrasd
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the icon for
shop/honeypreset frommaki-shoptofas-jar.maki-shopis a generic fallback icon.fas-jaris a more specific andaccurate icon for a honey shop, as honey is typically sold in jars.
fas-jaris available as a free Font Awesome iconfas-jar.svgalready exists in iD's fontawesome folder atsvg/fontawesome/fas-jar.svgTesting if this icon renders correctly in the preview as requested in the linked issue
Fixes #2017