Use multiple people icon for Coworking Space

[matkoniecz]

Description, Motivation & Context

replaces suitcase icon generic for office= icons

note that office=coworking is really distinct from other office=

Related issues

addresses part of #41

Links and data

Relevant OSM Wiki links:

https://wiki.openstreetmap.org/wiki/Tag:office=coworking

Relevant tag usage stats:

…

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

1. After you submit your PR, the system will create a preview and comment on your PR:

   🍱 Your pull request preview is ready.
   If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

2. Once the preview is ready, use it to test your changes.

3. Now copy the snippet below into a new comment and fill out the blanks.

4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

[github-actions]

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

[matkoniecz]

it is not really expressing office work part, but no idea how to fit into a tiny icon

[andrewharvey]

looks good to me

[matkoniecz]

hmm, maybe amenity=coworking_space also should be changed to have this icon?

both seem to describe the same thing and maybe one of them should outright copy preset, icon and terms etc of another one

[andrewharvey]

The amenity=coworking_space is hidden from search, so less important in my view, but I agree with making it have the new icon you're using here.

Even though the wiki documents the distinction between the two tags, I'm not convinced that's significant to have the two different tags. Even looking at spaces near me, there's no order to it, some use amenity some use office some use both even though they are all coworking office spaces (not a coworking studio/workshop). Though until the tagging is resolved or improved, I think having amenity=coworking_space as search hidden is best, so it's still shown when selected, but isn't presented when searching for a new preset.

+1 to merging this.

PS. Can I have maintainer status so I can provide proper reviews on GitHub?

[matkoniecz]

PS. Can I have maintainer status so I can provide proper reviews on GitHub?

I am pretty sure that comments without fancy green/red highlight are also valued. You can use the review functionality, just with "leave comment" mode, like I do in iD say at openstreetmap/iD#11810 (review)

And I am thankful for reviews you made so far!

But I will forward it to @tyrasd on our meeting next week (not sure who has ability to promote people, surely not me)

[andrewharvey]

I am pretty sure that comments without fancy green/red highlight are also valued. You can use the review functionality, just with "leave comment" mode, like I do in iD say at openstreetmap/iD#11810 (review)

That works too, as I've been doing.

But I will forward it to @tyrasd on our meeting next week (not sure who has ability to promote people, surely not me)

They are 2am local time for me, so I'm not willing enough to join.

[tyrasd]

PS. Can I have maintainer status so I can provide proper reviews on GitHub?

@andrewharvey you should now have the necessary rights to do "proper" PR reviews (see also 68602c9).

[matkoniecz]

@andrewharvey note that for technical reasons you have active buttons for closing PRs and merging PRs, but you should not use "merge" one (until 68602c9 I was in the same situation)

[andrewharvey]

@andrewharvey note that for technical reasons you have active buttons for closing PRs and merging PRs, but you should not use "merge" one (until 68602c9 I was in the same situation)

Thanks for clarifying that upfront, and documenting it through the governance doc.