Add 'art museum' search term to Museum preset#2073
Merged
tyrasd merged 1 commit intoopenstreetmap:mainfrom Mar 19, 2026
Merged
Conversation
Fixes openstreetmap#2026 - searching 'art museum' now surfaces the generic Museum preset in iD search results.
Collaborator
|
probably would be also fixed by openstreetmap/iD#9105 |
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
tyrasd
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2026
Searching "art museum" in iD currently returns only "History Museum" and "Area" , the generic "Museum" preset doesn't appear in results.
The base Museum preset already had
"art"as a single-word term, but iD's search doesn't combine it with the preset name to match multi-word queries. Adding"art museum"as a multi-word term ensures the Museum preset surfaces for this common search phrase.Changes
"art museum"to thetermsarray in data/presets/tourism/museum.json