Skip to content

Add preset for shop=truck_repair#2084

Open
Ambuj123554 wants to merge 3 commits intoopenstreetmap:mainfrom
Ambuj123554:add-truck-repair-preset
Open

Add preset for shop=truck_repair#2084
Ambuj123554 wants to merge 3 commits intoopenstreetmap:mainfrom
Ambuj123554:add-truck-repair-preset

Conversation

@Ambuj123554
Copy link
Copy Markdown
Contributor

@Ambuj123554 Ambuj123554 commented Mar 18, 2026

Description, Motivation & Context

Related issues

Closes #1213

What this PR does

Adds a new preset for shop=truck_repair — a shop that specialises in
repairing trucks and HGVs. Currently there is no preset for this tag,
meaning mappers have to manually type shop=truck_repair to use it.

Changes

  • Added data/presets/shop/truck_repair.json with appropriate fields,
    terms, and aliases for truck repair shops

Links and data

Relevant OSM Wiki links:

Tag usage stats:

Test-Documentation

Preview links & Sidebar Screenshots

Tested the Truck Repair Shop preset in the preview — preset appears
correctly with the right fields (Name, Operator, Address, Hours,
Payment Types).

image

Search

Searched "hgv" in edit mode — Truck Repair Shop appears at the top
of the results confirming the terms are working correctly.

image

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

Notes

Used GitHub Copilot for initial file structure assistance.

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@Ambuj123554
Copy link
Copy Markdown
Contributor Author

@matkoniecz just checking in — happy to make any changes if needed!

@matkoniecz
Copy link
Copy Markdown
Collaborator

@Ambuj123554 sorry for delay, as number of issues/PRs is quite noticeable they are not reviewed as fast as I would like

but there is no need for review requests, any opened one is waiting for review

Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would need truck-specific icon here

@matkoniecz matkoniecz added the waitfor-icon a matching icon is missing for this preset label Mar 24, 2026
@matkoniecz matkoniecz mentioned this pull request Mar 24, 2026
@Ambuj123554
Copy link
Copy Markdown
Contributor Author

we would need truck-specific icon here

@matkoniecz Done! Updated the icon to use temaki-truck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-preset waitfor-icon a matching icon is missing for this preset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shop=truck_repair

3 participants