Skip to content

Use dedicated geyser icon for geyser preset - thanks to quincylvania for an icon#2098

Merged
matkoniecz merged 2 commits intoopenstreetmap:mainfrom
ak8abhinay:use-geyser_from_ground-icon
Mar 30, 2026
Merged

Use dedicated geyser icon for geyser preset - thanks to quincylvania for an icon#2098
matkoniecz merged 2 commits intoopenstreetmap:mainfrom
ak8abhinay:use-geyser_from_ground-icon

Conversation

@ak8abhinay
Copy link
Copy Markdown
Contributor

Description:

Replaces maki-water with the newly added temaki-geyser_from_ground icon for the natural=geyser preset.

The current icon (maki-water) was nonspecific for natural=geyser, it was a generic water icon shared by several other presets.
Since there was no proper geyser-specific icon available in Temaki, I took a raw SVG from the Pinhead icon library (CC0), checked how Temaki icons are structured, and raised a PR#103-geyser_from_ground.svg to get it merged into the Temaki repo first. Once that got merged I came here to make this change.
So, first getting geyser_from_ground.svg into Temaki, and now using it here to replace the nonspecific icon in id-tagging-schema.

Fixes #2018

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@ak8abhinay
Copy link
Copy Markdown
Contributor Author

Waiting on a new Temaki release to include the merged geyser_from_ground icon before this can be verified. Will update once the package is published.

@matkoniecz matkoniecz added the waitfor-other This issue or PR is blocked by something that is not covered by other waitfor-* labels label Mar 20, 2026
@matkoniecz
Copy link
Copy Markdown
Collaborator

Also, release needs merge into iD

@matkoniecz matkoniecz added new-icon waiting-for-upstream and removed waitfor-other This issue or PR is blocked by something that is not covered by other waitfor-* labels labels Mar 20, 2026
@matkoniecz
Copy link
Copy Markdown
Collaborator

openstreetmap/iD#12124 was merged

@matkoniecz matkoniecz added waitfor-requested-changes This PR is waiting for an update to incorporate requested changes from a PR review. and removed waiting-for-upstream labels Mar 28, 2026
@ak8abhinay
Copy link
Copy Markdown
Contributor Author

Now that openstreetmap/iD#12124 is merged.
New icon should be available. I will trigger a rebuild of the preview to confirm the new icon.

@ak8abhinay
Copy link
Copy Markdown
Contributor Author

Here is how the icon looking in preview. It is rendering perfectly.

image

@matkoniecz matkoniecz removed the waitfor-requested-changes This PR is waiting for an update to incorporate requested changes from a PR review. label Mar 30, 2026
Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@matkoniecz matkoniecz changed the title Use dedicated geyser icon for geyser preset Use dedicated geyser icon for geyser preset - thanks to quincylvania for an icon Mar 30, 2026
@matkoniecz matkoniecz merged commit 6aacd0d into openstreetmap:main Mar 30, 2026
5 checks passed
@matkoniecz
Copy link
Copy Markdown
Collaborator

Thanks for the PR! It is now merged but note that before you will see it in iD few things need to happen.

iD tagging schema needs to get release (see https://github.com/openstreetmap/id-tagging-schema/releases - latest one mentioned there is just a draft). And later needs to be pulled in by iD.

Thanks again for your contribution! If you are interested in making other one it would be really welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use dedicated icon for geyser

2 participants