Skip to content

add cycleway as an optional field to service roads#2102

Merged
tyrasd merged 2 commits intomainfrom
matkoniecz-patch-31
Mar 23, 2026
Merged

add cycleway as an optional field to service roads#2102
tyrasd merged 2 commits intomainfrom
matkoniecz-patch-31

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

fixes #2100

service roads may have some cycleway features

Description, Motivation & Context

Related issues

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

fixes #2100

service roads may have some cycleway features
@matkoniecz matkoniecz added bug Something isn't working add-field add existing field to more entries, for field creation see new-field labels Mar 20, 2026
@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

tested, confirmed to be fixed

Copy link
Copy Markdown
Collaborator

@k-yle k-yle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is a good change, and imo we should also add this field to highway=trunk (where it's used 67129 times, or 47010 times if you exclude !=no).

tyrasd
tyrasd previously approved these changes Mar 21, 2026
@tyrasd tyrasd changed the title add cycleway to service roads add cycleway as an optional field to service roads Mar 21, 2026
@tyrasd tyrasd dismissed their stale review March 21, 2026 12:35

clicked prematurely

Copy link
Copy Markdown
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO it is a bit silly that after this change now also any parking aisle or drive through would offer the cycleway field as an optional field. 🤷

Also, cycleway tags on highway=service roads are extremely rare: only 0.13% have them tagged and almost all of them are cyclway:*=no.

Maybe an alternative approach to address these issues as outlined in #2103 (comment) would be less dubious?

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

Also, cycleway tags on highway=service roads are extremely rare: only 0.13% have them tagged and almost all of them are cyclway:*=no.

at least in my city some main cycleway routes (re)use highway=service and some of them get some specific cycleway= features

so I do not see this only as workaround for the raised bug, and I think it is worth to show this field, if tagged, and offer in moreFields

maybe ideally parking aisles would be excluded but it would be so annoying to achieve it to make it not worth it with the current setup

@matkoniecz matkoniecz removed the bug Something isn't working label Mar 23, 2026
@matkoniecz
Copy link
Copy Markdown
Collaborator Author

And https://www.openstreetmap.org/way/820193969 has another case (maybe taggable as parking aisle)

@tyrasd tyrasd merged commit 2676273 into main Mar 23, 2026
8 checks passed
@matkoniecz matkoniecz deleted the matkoniecz-patch-31 branch March 23, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-field add existing field to more entries, for field creation see new-field

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removed cycleway tags on highway=service

3 participants