add missing colon in tag key of plant:output multiCombo field#2186
Merged
matkoniecz merged 1 commit intomainfrom Apr 15, 2026
Merged
add missing colon in tag key of plant:output multiCombo field#2186matkoniecz merged 1 commit intomainfrom
plant:output multiCombo field#2186matkoniecz merged 1 commit intomainfrom
Conversation
this worked in iD as there was a fallback in place to add the colon if missing, but the convention is to always include it in the `key` property for any multiCombo field.
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
matkoniecz
approved these changes
Apr 15, 2026
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this still works in iD even without the fix, because there is a fallback in place to add the colon if missing, but our convention is to always include the
:in thekeyproperty for all multiCombo fields.