Add hidden preset for shop=ice_cream referencing amenity=ice_cream#2195
Open
matkoniecz wants to merge 1 commit intoopenstreetmap:mainfrom
Open
Add hidden preset for shop=ice_cream referencing amenity=ice_cream#2195matkoniecz wants to merge 1 commit intoopenstreetmap:mainfrom
matkoniecz wants to merge 1 commit intoopenstreetmap:mainfrom
Conversation
these are effectively the same thing (though there were attempts to argue for obscure differences - disclaimer: I participated in these discussions) this adds no work for translators shop=ice_cream should be supported somehow either way BTW, I prefer shop=ice_cream over amenity=ice_cream but I guess that I should focus on more useful things than tagfiddling this one fixes part of openstreetmap#1641 - alternative would be to add this tag to list of ignored and unsupported ones
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
tordans
approved these changes
Apr 18, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description, Motivation & Context
these are effectively the same thing (though there were attempts to argue for obscure differences - disclaimer: I participated in these discussions) this adds no work for translators
shop=ice_cream should be supported somehow either way
BTW, I prefer shop=ice_cream over amenity=ice_cream but I guess that I should focus on more useful things than tagfiddling this one
Related issues
fixes part of #1641 - alternative would be to add this tag to list of ignored and unsupported ones
Links and data
Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Tag%3Ashop%3Dice_cream
Relevant tag usage stats:
https://taginfo.openstreetmap.org/tags/shop=ice_cream
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.