Skip to content

Add hidden preset for shop=ice_cream referencing amenity=ice_cream#2195

Open
matkoniecz wants to merge 1 commit intoopenstreetmap:mainfrom
matkoniecz:ice_cream
Open

Add hidden preset for shop=ice_cream referencing amenity=ice_cream#2195
matkoniecz wants to merge 1 commit intoopenstreetmap:mainfrom
matkoniecz:ice_cream

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

Description, Motivation & Context

these are effectively the same thing (though there were attempts to argue for obscure differences - disclaimer: I participated in these discussions) this adds no work for translators
shop=ice_cream should be supported somehow either way

BTW, I prefer shop=ice_cream over amenity=ice_cream but I guess that I should focus on more useful things than tagfiddling this one

Related issues

fixes part of #1641 - alternative would be to add this tag to list of ignored and unsupported ones

Links and data

Relevant OSM Wiki links:

https://wiki.openstreetmap.org/wiki/Tag%3Ashop%3Dice_cream

Relevant tag usage stats:

https://taginfo.openstreetmap.org/tags/shop=ice_cream

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

these are effectively the same thing (though there were attempts to argue for obscure differences - disclaimer: I participated in these discussions)
this adds no work for translators
shop=ice_cream should be supported somehow either way

BTW, I prefer shop=ice_cream over amenity=ice_cream but I guess that I should focus on more useful things than tagfiddling this one

fixes part of openstreetmap#1641 - alternative would be to add this tag to list of ignored and unsupported ones
@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

screen-2026-04-18-15-56-25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants