Add presets for German bicycle DE:240#345
Closed
tordans wants to merge 1 commit intoopenstreetmap:mainfrom
Closed
Conversation
0d90338 to
eeca6f1
Compare
4 tasks
9d3204d to
49f529e
Compare
eeca6f1 to
90fd334
Compare
- only for Germany, since it's a German traffic sign - one preset for the tagging in combination with `highway=path`, which is dominant (25k) and one un-searchable for `highway=cycleway` (3k) https://taginfo.openstreetmap.org/tags/?key=traffic_sign&value=DE%3A240#combinations - the unsearchable uses the same `fields+moreFields` as the main preset - the `imageUrl` (https://github.com/ideditor/schema-builder/blob/main/schemas/preset.json#L62-L65) is the traffic sign from https://wiki.openstreetmap.org/wiki/DE:Tag:traffic_sign%3DDE:240 - the presets match on the two main tags and add the `addTags` or suggest to do so - should a mapper switch the preset back to something else, `removeTags` should remove the special tags that the mapper should re-add manually - the list of `fields+moreFields` are optimized for Germany: name move to moreFields (not commonly present on cycleways), segregated was added, sort order was changed for logical groups - the cycleway with `highway=path`-preset it still in the cycleway-folder, to keep them together
90fd334 to
bea33cf
Compare
|
🍱 Preview the tagging presets of this pull request here: https://pr-345--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
Collaborator
Author
|
Closing this now. I don't think that adding traffic signs as presets will work. I will continue working on https://trafficsigns.osm-verkehrswende.org/ instead, soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview for
w59463482Next steps
Related to #267.
Commit
traffic_sign=DE:240eeca6f1 is a first take at #267.Let's first see if this makes sense before adding more of those tags.
I looked into the other wiki pages from #267. Adding those would require quite a few unsearchable presets with shared fields/moreFields to get the desired result. Mainly, because there are small changes in the
traffic_signvalue that have affect on the access values which require a new preset (right?). — Is it a good idea to go down this road further?