update lifeboat station preset#382
Merged
tyrasd merged 3 commits intoopenstreetmap:mainfrom Feb 1, 2022
Merged
Conversation
tyrasd
added
new-field
tyrasd
requested changes
Feb 1, 2022
Member
tyrasd
left a comment
tyrasd
left a comment
There was a problem hiding this comment.
Thanks! A few small remarks are below.
PS: It's a bit annoying that there is also amenity=lifeboat_station with very similar usage than emergency=lifeboat_station (many features are currently mapped using both of these tags). But I think the preset is fine since the emergency is arguably a more precise tag.
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
Collaborator
Author
|
thanks, I've made both changes |
tyrasd
approved these changes
Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Lifeboat Station" preset was added in 072d2dd (#76), but without any fields to further describe the lifeboat station.
This PR adds the
seamark:rescue_station:categoryfield to let you specify what amenities the lifeboat station has (e.g. a lifeboat, seaplane, first aid, etc.)This PR also suggests adding
seamark:type=rescue_stationto these features, so that they render in OpenSeaMap.