Garage(s): Only keep capacity as fields#423
Merged
tyrasd merged 4 commits intoopenstreetmap:mainfrom May 12, 2022
Merged
Conversation
Move fields from from https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/building.json to the moreFields section to only show very relevant fields by default.
fields
fieldsfields
… and use template syntax to tidy up moreFields list slightly
and also copy "moreFields" from building/garages preset
Member
This inheritance works separately for See ideditor/schema-builder#53 for further potential enhancements in this direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move fields from from https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/building.json to the moreFields section to only show very relevant fields by default.
When using those presets I noticed that I tend to add the capacity to the level or height fields instead of the capacity fields. Since those (and all other) are not really common on garages, we should move the to the moreFields.
Would it be possible to write the code like this which could result in the same but a better data structure. However, I am not sure if the moreField would just merge the fields + moreFields values if used like this.