Skip to content

Add some more values to beauty=*#427

Merged
tyrasd merged 3 commits intoopenstreetmap:mainfrom
Zverik:patch-1
May 17, 2022
Merged

Add some more values to beauty=*#427
tyrasd merged 3 commits intoopenstreetmap:mainfrom
Zverik:patch-1

Conversation

@Zverik
Copy link
Copy Markdown
Collaborator

@Zverik Zverik commented Mar 26, 2022

Added some frequent non-ambigous values from taginfo and wiki.

Zverik and others added 2 commits March 26, 2022 23:36
see https://wiki.openstreetmap.org/wiki/Key%3Abeauty:

* use descriptions from wiki
* waxing has similar number of uses as the other new values (see https://taginfo.openstreetmap.org/keys/beauty#values)
* the value "hair" is not documented on wiki (probably because of the overlap with shop=hairdresser)
@tyrasd tyrasd added the new-value adds value(s) to existing field label May 12, 2022
@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented May 12, 2022

see my tweaks in 7ef7f8d: what do you think?

@Zverik
Copy link
Copy Markdown
Collaborator Author

Zverik commented May 12, 2022

Yeah, looks good. hair_removal is indeed described in the wiki and has enough usages.

@Zverik
Copy link
Copy Markdown
Collaborator Author

Zverik commented May 12, 2022

Although I'd argue "Spa" is a wide-understood term that people would search for.

@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented May 12, 2022

Although I'd argue "Spa" is a wide-understood term that people would search for.

I had always associated the term "spa" exclusively with thermal baths (see wikipedia: https://en.wikipedia.org/wiki/Spa) to be honest. Perhaps "Spa Treatment" would be a better description instead of "Hydrotherapy" (but on the other hand, spa treatment can apparently be used for basically any beauty treatment)?
@1ec5 would you mind sharing your opinion as a native speaker?

Comment thread data/fields/beauty.json Outdated
@tyrasd tyrasd merged commit 6db50ed into openstreetmap:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-value adds value(s) to existing field

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants