Skip to content

move aliases of highway=track from terms to aliases field #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrasd merged 8 commits into from
Sep 29, 2022
Merged

move aliases of highway=track from terms to aliases field #470

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5df6c79
move aliases of highway=track from terms to aliases field
westnordost May 26, 2022
6103f35
remove those pesky tabs
westnordost May 26, 2022
f768642
sort all aliases alphabetically
westnordost May 26, 2022
ddc1c3d
remove trailing ","
westnordost May 26, 2022
f1a5b35
add suggestions from review
westnordost Sep 29, 2022
32c8e1a
sort alphabetically
westnordost Sep 29, 2022
73a83c5
update source_strings.yaml
westnordost Sep 29, 2022
833f3d0
Merge branch 'main' into track-aliases
westnordost Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions data/presets/highway/track.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,29 +30,34 @@
"terms": [
"4wd",
"4x4",
"agricultural road",
"atv",
"carriage road",
"double track",
"farm road",
"fire road",
"forest road",
"four wheel drive",
"high-clearance",
"jeep",
"land access road",
"logging road",
"offroad",
"off-road",
"overgrown",
"primitive",
"quad",
"ranch road",
"rut",
"track",
"track road",
"two track",
"unmaintained",
"woods road"
"unmaintained road",
"dirt road"
Copy link
Copy Markdown
Member

@tyrasd tyrasd May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep terms sorted alphabetically. 🤓

Copy link
Copy Markdown
Contributor Author

@westnordost westnordost May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize they were before. So, should I change this?

Copy link
Copy Markdown
Member

@tyrasd tyrasd May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please

Copy link
Copy Markdown
Contributor

@1ec5 1ec5 May 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iD ranks terms by their position in the list, so sorting them alphabetically promotes some rarer terms over more common terms. This might be less of a problem now that some terms are aliases, but it’s hard to test.

Copy link
Copy Markdown
Contributor Author

@westnordost westnordost May 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? Is this documented somewhere (+documented for translators)?

Copy link
Copy Markdown
Contributor

@1ec5 1ec5 May 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, either I’m mistaken or it’s no longer in place. It looks like nowadays iD only considers the index of a match against the preset name but only filters by terms.

],
"name": "Track / Land-Access Road"
"name": "Track / Land-Access Road",
"aliases": [
"Land-Access Road",
"Track Road",
"Logging Road",
"Woods Road",
"Forest Road",
"Forestry Road",
"Ranch Road",
"Farm Road",
"Agricultural Road",
"Fire Road",
"Carriage Road",
"Two-Track Road"
]
Comment thread
westnordost marked this conversation as resolved.
}
4 changes: 2 additions & 2 deletions interim/source_strings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6300,8 +6300,8 @@ en:
terms: <translate with synonyms or related terms for 'Open Road Toll', separated by commas>
highway/track:
# highway=track | Translate the primary name. Optionally, add equivalent synonyms on newlines in order of preference (press the Return key).
name: Land Access / Track Road
# 'terms: 4wd,4x4,agricultural road,atv,carriage road,double track,farm road,fire road,forest road,four wheel drive,high-clearance,jeep,land access road,logging road,offroad,overgrown,primitive,quad,ranch road,rut,track,track road,two track,unmaintained,woods road'
name: Track / Land-Access / Road
# 'terms: 4wd,4x4,atv,double track,four wheel drive,high-clearance,jeep,offroad,off-road,overgrown,primitive,quad,rut,unmaintained,unmaintained road,dirt road'
terms: <translate with synonyms or related terms for 'Land Access / Track Road', separated by commas>
highway/traffic_mirror:
# highway=traffic_mirror | Translate the primary name. Optionally, add equivalent synonyms on newlines in order of preference (press the Return key).
Expand Down
⚡