Add aliases and terms for shop=* presets#475
Merged
tyrasd merged 11 commits intoopenstreetmap:mainfrom Aug 8, 2022
Merged
Conversation
…name Sources: English Wikipedia, OpenStreetMap Wiki
ZeLonewolf
reviewed
May 31, 2022
ZeLonewolf
reviewed
May 31, 2022
ZeLonewolf
reviewed
May 31, 2022
ZeLonewolf
reviewed
May 31, 2022
ZeLonewolf
reviewed
May 31, 2022
ZeLonewolf
reviewed
May 31, 2022
ZeLonewolf
reviewed
May 31, 2022
1ec5
reviewed
May 31, 2022
zekefarwell
reviewed
May 31, 2022
ZeLonewolf
reviewed
May 31, 2022
zekefarwell
reviewed
Jun 1, 2022
1ec5
reviewed
Jun 1, 2022
Contributor
Author
|
Alright, thanks for the review you all. All suggestions are incorporated now. This PR is ready for final review by the repo maintainer(s). |
zekefarwell
approved these changes
Jun 3, 2022
8 tasks
tyrasd
force-pushed
the
main
branch
2 times, most recently
from
9d3204d to
49f529e
Compare
tyrasd
requested changes
Aug 7, 2022
Member
tyrasd
left a comment
tyrasd
left a comment
There was a problem hiding this comment.
👍 Thanks for the PR and please excuse the rather long delay. Please see a few minor questions and remarks below.
Contributor
Author
|
Ready for re-review. |
michaelblyons
approved these changes
Aug 7, 2022
tyrasd
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, corrected
shop=delipreset name. In American English, "Deli" means something else as whatshop=deliis originally defined with.Sources: English Wikipedia, OpenStreetMap Wiki