Skip to content

add two popular building values#528

Merged
tyrasd merged 3 commits intoopenstreetmap:mainfrom
matkoniecz:100k
Jul 18, 2022
Merged

add two popular building values#528
tyrasd merged 3 commits intoopenstreetmap:mainfrom
matkoniecz:100k

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz commented Jul 12, 2022

https://taginfo.openstreetmap.org/tags/building=outbuilding#overview

https://taginfo.openstreetmap.org/tags/building=allotment_house#overview

building=outbuilding is popular, but this is fueled by imports from PRG in Poland, not an organic growth (at least as of 2022-07), so this unspecific value is unsearchable

@tyrasd Would you be interested in listing of popular unsupported values for say shop amenity barrier leisure natural (with adjusted thresholds, lower than 100k used for buildings)?

I believe that JOSM has similar script that is listing popular tags (keys?) and they maintain list of popular tags which are deliberately not supported.

building=outbuilding is popular, but this is fueled by imports from PRG in Poland, not an organic growth (at least as of 2022-07), so this unspecific value is unsearchable
Copy link
Copy Markdown
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor tweaks (see below)

Comment thread data/presets/building/allotment_house.json Outdated
Comment thread data/presets/building/_outbuilding.json Outdated
Comment thread data/presets/building/allotment_house.json Outdated
matkoniecz and others added 2 commits July 12, 2022 13:26
Co-authored-by: Martin Raifer <martin@raifer.tech>
Apply suggestions from code review

Co-authored-by: Martin Raifer <martin@raifer.tech>
@matkoniecz matkoniecz requested a review from tyrasd July 12, 2022 11:27
@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Jul 12, 2022

//cc @1ec5 do you think these names are acceptable in en-US?

@tyrasd tyrasd merged commit 4181cd2 into openstreetmap:main Jul 18, 2022
@matkoniecz matkoniecz deleted the 100k branch July 18, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants