Add a field for the key "model"#584
Conversation
Hi, the key "model" ( https://wiki.openstreetmap.org/wiki/Key%3Amodel ) describes the model designation of a manufactured object. Formerly, it has been used for power=generator mainly, but now its usage has increased and is spread around over vrious objects which can have a model-designation / model-name. For example public telephones, elevators, street cabinets, substations and so on. ***It is used over 32000 times.*** So I think it's worth adding it. The kind of field should be free-text generally, but I chose the field type "combo" so that people can orientate on which values are already in use. For this, there's also the case-sensivity important.
tyrasd
added
the
new-field
There was a problem hiding this comment.
This PR is missing the inclusion of the new field in the respective presets. Can you add it add it as an optional field (moreFields) at least to the street_cabinet preset and any other presets where you think it should be included, please?
It' s unfortunate that for find turbines, the manufacturer:type tag is used more frequently than the model tag. But there is a proposal on the way to deprecate that tag in favor of model, so I think it is reasonable to only support model in iD for now.
Oh sorry, I wrongly thought that the new-field.json needed to come first and this work needs to come after then. Of course I can add it to some presets, I will do that then.
Oh yes, I see, another case where for some single main-tag a special under-tag had been created/used. I share your opinion that |
I added the key "model" in "more Fields" to it, see PR openstreetmap#584
I added the key "model" in "more Fields" to it, see PR openstreetmap#584
…ore Fields", "covered" to "fields" I added the key "model" in "more Fields" to it, see PR openstreetmap#584 Also, I changed the key "covered" to the "fields", because "booth" is rather optional, not everny public telephone has a booth at all. booth=* is usually only used **if** it has a booth. The key "covered" is more wiedespread to indentify whether the telephone is covered at all or isn't. Please note I only changed the position of the fields, both keys can be used normally as before.
|
merged, thanks! |
2 participants
Hi,
the key "model" ( https://wiki.openstreetmap.org/wiki/Key%3Amodel ) describes the model designation of a manufactured object. Formerly, it has been used for power=generator mainly, but now its usage has increased and is spread around over various objects which can have a model-designation / model-name. For example public telephones, elevators, street cabinets, substations and so on. It is used over 32000 times. So I think it's worth adding it. The kind of field should be free-text generally, but I chose the field type "combo" so that people can orientate on which values are already in use. For this, there's also the case-sensivity important.