Skip to content

This add amenity=stripclub #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrasd merged 2 commits into from
Feb 16, 2023
+40 −0
Merged

This add amenity=stripclub #648

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5649b76
add: amenity=stripclub
EvanCarroll Nov 20, 2022
f1bc7f2
switch out icon
tyrasd Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions data/presets/amenity/stripclub.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
{
"icon": "fas-place-of-worship",
Copy link
Copy Markdown
Member

@tyrasd tyrasd Nov 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this icon is a good match for this tag.

Copy link
Copy Markdown
Contributor Author

@EvanCarroll EvanCarroll Nov 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a strip club to me. Big door, no windows, big grand entrance. The icon itself is a pretty close match.

02-outside-ch3

stripclub

What is your reservation? Is there a better suggestion?

Copy link
Copy Markdown
Contributor

@1ec5 1ec5 Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’re trying not to reuse preset icons so much, especially for quite unrelated features: #41. Sounds like you’re aware of the need for something more specific: FortAwesome/Font-Awesome#8254 (comment). The icon can come from a few sources besides FontAwesome, including a custom-drawn icon if you prefer to draw something yourself.

Copy link
Copy Markdown
Member

@bhousel bhousel Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just use temaki-money_hand until something better comes along.

temaki-money_hand

Copy link
Copy Markdown
Contributor Author

@EvanCarroll EvanCarroll Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temaki-money_hand doesn't look at all like a strip club. Normally, afaik, you don't hand strippers money either. You either (a) make it rain, or (b) affix the money to the stripper. Or so I've read.

But more important temaki-money_hand would also be reused.

So the question remains, what icon should I use? I have 0 artistic skill.

Copy link
Copy Markdown
Contributor Author

@EvanCarroll EvanCarroll Nov 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1ec5 someone else can create it for me then. I think I made a good-faith suggestion above and I don't think there is any problem with reuse elsewhere in the project. Seems many of the icons are not unique. Not an artist, I'll leave it for someone else. Tell/tag me when you me to edit the patch with the new desired name.

Copy link
Copy Markdown
Contributor

@1ec5 1ec5 Nov 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think either your suggestion (with the color modification I mentioned) or @tyrasd’s suggestion could work. I just didn’t want us to overthink it. You’re right that many of the icons aren’t unique yet – it’s something we’re working towards, but new presets should at least avoid reusing an icon that’s completely unrelated. We’ve already have several instances where FontAwesome dramatically changed the look of an icon while keeping it semantically consistent with the file name.

Copy link
Copy Markdown
Contributor Author

@EvanCarroll EvanCarroll Nov 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also open the request in Temaki for a new icon. Not being a hardass on the art stuff either. I just suck with the open source software on it. I spent 2 hours trying to figure out how to draw a box, asked a question on it, and 12 years later its since helped 150k people: How do I draw a box in GIMP?. I still have to google for how to draw a box in GIMP. GIMP is terrible, and I don't have a VM with photoshop. =(

rapideditor/temaki#80

Copy link
Copy Markdown
Contributor

@1ec5 1ec5 Nov 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I feel your pain. I find vector drawing in Inkscape to be much more intuitive, and as it turns out, projects like Temaki and FontAwesome require vector graphics in SVG format.

Copy link
Copy Markdown
Contributor Author

@EvanCarroll EvanCarroll Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've actually only ever heard good things about Inkscape, I'll check it out. It's open source. As long as it's not gimp.

"fields": [
"name",
"operator",
"address",
"building_area_yes",
"opening_hours",
"min_age",
"smoking"
],
"moreFields": [
"air_conditioning",
"email",
"fax",
"gnis/feature_id-US",
"level",
"payment_multi",
"opening_hours/covid19",
"phone",
"ref/FR/siret-FR",
"wheelchair",
"fee"
],
"geometry": [
"point",
"area"
],
"tags": {
"amenity": "stripclub"
},
"terms": [
"lap dance",
"adult*",
"gentlemen*",
"cabaret",
"strip*"
Comment thread
tyrasd marked this conversation as resolved.
],
"name": "Strip club"
}
⚡