Skip to content

Add translatable strings to traffic_calming type field #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrasd merged 3 commits into from
Dec 22, 2022
Merged

Add translatable strings to traffic_calming type field #699

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd5e36d
Add translatable strings to traffic_calming type field
kjonosm Dec 21, 2022
5ce978d
Update data/fields/traffic_calming.json
kjonosm Dec 22, 2022
081856b
omit value `choked_island` for now
tyrasd Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion data/fields/traffic_calming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,22 @@
"hump",
"speed",
"slow"
]
],
"strings": {
"options": {
"bump": "Speed Bump",
"chicane": "Traffic Chicane",
"choker": "Traffic Choker",
"choked_island": "Choked Traffic Island",
Copy link
Copy Markdown
Member

@tyrasd tyrasd Dec 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage for this value is currently pretty low (73 occurrences as of today).

At first glance, the wording of this value could also be slightly confusing as (almost) every traffic island is inherently also a choke point, as the road lanes need to make space for the width of the traffic island. 🤔

I've looked through a sample of places where this tag is currently used, and only found one place which I would classify as a valid use of this tag value (node 7183898498, which is also the example used to illustrate this on the OSM wiki). All other examples I found were either misclassified regular choke points or regular traffic islands: 1, 2, 3, 4, 5, 6, 7, 8, 9.

I'd say it's probably better to omit this value for now.

"choked_table": "Choked Speed Table",
"cushion": "Speed Chushion",
"dip": "Dip",
"double_dip": "Double Dip",
"hump": "Speed Hump",
"island": "Traffic Island",
"mini_bumps": "Mini Speed Bumps",
"rumble_strip": "Rumble Strip",
"table": "Speed Table"
}
}
}
⚡