Skip to content

Update sport.json#812

Merged
tyrasd merged 1 commit intoopenstreetmap:mainfrom
kjonosm:patch-31
Mar 14, 2023
Merged

Update sport.json#812
tyrasd merged 1 commit intoopenstreetmap:mainfrom
kjonosm:patch-31

Conversation

@kjonosm
Copy link
Copy Markdown
Contributor

@kjonosm kjonosm commented Mar 11, 2023

Add some more sports, see #529
Replace sport=rugby_union with sport=rugby as recommended according to OSM wiki.

@tyrasd tyrasd added new-value adds value(s) to existing field deprecating labels Mar 13, 2023
Copy link
Copy Markdown
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the additional values, but I'm not quite sure what best to do with the rugby values. https://wiki.openstreetmap.org/wiki/Tag:sport%3Drugby says that

[…] a consensus has since emerged. It is advised to solely use the primary tag sport=rugby. From there, if you know the version of rugby played at the location you are mapping, you can add a minor tag of rugby=union or rugby=league.

Although no source for where exactly this consensus was found is given (I assume it was a discussion on the talk mailing list), the sport=rugby approach does seem reasonable to me.

However, the wiki is not consistent on this: The Key:sport page does not list sport=rugby at all and the Tag:sport=rugby_* subpages do only slightly hint towards the sport=rugby tag and not list the values themselves as discouraged or deprecated. Further, usage numbers of the "old" tags do not seem to slow down. 🤔

Lastly, if we were going ahead with replacing sport=rugby_union with sport=rugby, I think we should also do the following:

  • update the tags of the preset for Rugby League Field
  • update the tags of the preset for Rugby Union Field
  • add deprecation rules for sport=rugby_league to sport=rugby + rugby=league and for sport=rugby_union to sport=rugby + rugby=union

@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Mar 14, 2023

I've merged this without the proposed change to the rugby value for now. Let's track that in #820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-value adds value(s) to existing field

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants