Skip to content

try more dedicated icon for sign maker#839

Merged
tyrasd merged 3 commits intoopenstreetmap:mainfrom
matkoniecz:patch-9
Mar 27, 2023
Merged

try more dedicated icon for sign maker#839
tyrasd merged 3 commits intoopenstreetmap:mainfrom
matkoniecz:patch-9

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz commented Mar 25, 2023

see #41

@github-actions
Copy link
Copy Markdown

🍱 Preview the tagging presets of this pull request here: https://pr-839--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

matkoniecz commented Mar 25, 2023

Sadly, it has not worked. Not sure why.

Tried to use https://fontawesome.com/icons/signs-post?f=classic&s=solid

@matkoniecz matkoniecz changed the title try more dedicated icon (#41) try more dedicated icon for sign maker Mar 25, 2023
@matkoniecz matkoniecz marked this pull request as draft March 25, 2023 17:01
@matkoniecz matkoniecz marked this pull request as ready for review March 27, 2023 17:03
@matkoniecz
Copy link
Copy Markdown
Collaborator Author

screen

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

Thanks so much for the fix!

@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Mar 27, 2023

I'm wondering whether https://fontawesome.com/icons/sign-hanging?f=classic&s=solid would be even more fitting?

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

yes, seems better as it is far more likely that they will make one looking like this

@tyrasd tyrasd merged commit 6a5779d into openstreetmap:main Mar 27, 2023
@matkoniecz matkoniecz deleted the patch-9 branch March 27, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants