stop assuming that all shop=organic are supermarkets

[matkoniecz]

also, some may be organic=yes so even migrating to shop=yes is not viable - this requires human review

[github-actions]

🍱 Preview the tagging presets of this pull request here: https://pr-884--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

[Hufkratzer]

Another alternative would probably be shop=convenience + organic=yes/only. Maybe iD can be enhanced to allow the user to select from two or more alternatives. This could also be used for other tags, e.g. for sport=diving, which could be scuba_diving or cliff_diving.

[tyrasd]

Agree that the current tag upgrade is not general applicable. Other examples for shop types where shop=organic might have been used include shop=herbalist, shop=cosmetics, etc. ~ Ideally we'd need a more interactive deprecation resolution process where users have to choose from a list of possible cases or values. But as that is not currently implemented, I think it is fine to just drop the rule for not and let other QA tools take care of this tag.

some may be organic=yes

While this is true in a strict sense, it is IMO reasonable to assume that a user would not have chosen shop=organic as a tag for a shop which does not have a very strong focus on organic products, i.e. organic=yes would not be fitting well in such cases.

[matkoniecz]

While this is true in a strict sense, it is IMO reasonable to assume that a user would not have chosen shop=organic as a tag for a shop which not have a very strong focus on organic products, i.e. organic=yes would not be fitting well in such cases.

though organic=only is extremely strong

(but with such interpretation migration to shop=yes organic=only would be viable)

[tyrasd]

I always read the wiki that organic=only does not mean that literally only organic products are offered:

All or almost all of the products the shop or restaurant offers are organic. These institutions normally promote themself as "organic"

(highlights by me)

shop=yes organic=only would be viable

Sure, but I would argue that such a tag change would only "hide" the underlying data quality problem we have with this tag: We still don't know which shop type this is and in general some manual research is needed to fix that. Basically, the tag deprecation / upgrade rules here are just not a good place for this type of data quality issue.

[matkoniecz]

would only "hide" the underlying data quality problem we have with this tag: We still don't know which shop type this is

shop=yes communicates exactly this (and triggers complaints/special support in few tools like JOSM/StreetComplete/good part of Osmose that copied JOSM errors and shows in iD as underspecified)

while shop=organic shows like thousands of other ATYL shop types (many of them valid!)

[tyrasd]

ok, good point. Let's change it to shop=yes then 👍

//edit: done in 0a8c721