Skip to content

Add "Unspecified Type" to generic crossing presets#885

Closed
Dimitar5555 wants to merge 1 commit intoopenstreetmap:mainfrom
Dimitar5555:patch-1
Closed

Add "Unspecified Type" to generic crossing presets#885
Dimitar5555 wants to merge 1 commit intoopenstreetmap:mainfrom
Dimitar5555:patch-1

Conversation

@Dimitar5555
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

🍱 Preview the tagging presets of this pull request here: https://pr-885--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@tyrasd tyrasd added the new-label changes the name, aliases or terms of a preset label Apr 24, 2023
@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Apr 24, 2023

Could you please comment on the reasoning behind this change? Because, I would have said that for these presets, it would be reasonable to keep the current name: Adding the (Unspecified Type) suffix is intended to make it very clear that a preset does not make much sense without further specifying a concrete sub-type (e.g. shop=yes or barrier=yes, etc.). In this case, the situation where this preset is found is a bit different though: "only" the additional crossing tag is missing, and sometimes a mapper might not know or remember the exact type of the crossing.

Instead, we should probably consider to make these presets searchable, as we did for the vertex version of it in #837

@Dimitar5555
Copy link
Copy Markdown
Contributor Author

Superseded by #889

Could you please comment on the reasoning behind this change?

I wanted to make it inline with the generic shop and barrier presets.

@Dimitar5555 Dimitar5555 deleted the patch-1 branch April 25, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-label changes the name, aliases or terms of a preset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants