Skip to content

Add 'cyclestreet'-field #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrasd merged 5 commits into from
May 5, 2023
Merged

Add 'cyclestreet'-field #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f572199
Add 'cyclestreet'-field
pietervdvn Apr 25, 2023
ca1035d
Add countries-whitelist to cyclestreet-field, run lint
pietervdvn Apr 26, 2023
cead6ec
Move cyclestreet.json to cyclestreet-BE-NL; add to living_street and …
pietervdvn Apr 30, 2023
574ebeb
Actually add cyclestreet field
pietervdvn May 5, 2023
29e639b
tweak spelling slightly, add terms
tyrasd May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions data/fields/cyclestreet-BE-NL.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"key": "cyclestreet",
"type": "defaultCheck",
"label": "Cycle Street",
"terms": [
"bicycle boulevard",
"bicycle road",
"cyclestreet",
"neighborhood bikeway",
"neighborhood byway",
"neighborhood greenway",
"neighborway"
],
"locationSet": {
"include": [
"BE",
"NL"
]
},
"strings": {
"options": {
"undefined": "No",
"yes": "Yes"
}
}
}
1 change: 1 addition & 0 deletions data/presets/highway/living_street.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
],
"moreFields": [
"covered_no",
"cyclestreet-BE-NL",
"cycleway",
"flood_prone",
"junction_line",
Expand Down
1 change: 1 addition & 0 deletions data/presets/highway/residential.json
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@1ec5 1ec5 Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a cyclestreet guaranteed to be a highway=residential, or can it also be on a road classified differently, like unclassified or service?

Copy link
Copy Markdown
Contributor Author

@pietervdvn pietervdvn Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unclassified-highway copies all 'extra'-tags from residential. This new field should thus appear at unclassified as well.

For the other types, I ran the numbers with a global overpass-entry and a little script:

Amount highway-type
7864 residential (71.2%)
1378 unclassified (12.4%)
806 tertiary (7.3%)
339 living_street (3%)
152 secondary
139 service
115 pedestrian
79 cycleway
53 track
33 primary
25 footway
21 path
9 null
7 construction
3 tertiary_link
3 proposed
2 primary_link
1 street_lamp
1 secondary_link

I have to admit I'm a bit surprised by the high amount of tertiary roads in there, I suspected them to be less.

Also, it doesn't really make sense on some values, at least not from the perspective of a Belgian ;) (e.g. primary or 'street_lamp')

Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"moreFields": [
"covered_no",
"cycleway",
"cyclestreet-BE-NL",
"flood_prone",
"incline",
"junction_line",
Expand Down
3 changes: 2 additions & 1 deletion data/presets/highway/tertiary.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"{highway/primary}"
],
"moreFields": [
"{highway/primary}"
"{highway/primary}",
"cyclestreet-BE-NL"
],
"geometry": [
"line"
Expand Down
9 changes: 9 additions & 0 deletions interim/source_strings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1502,6 +1502,15 @@ en:
cycle_network:
# cycle_network=*
label: Network
cyclestreet-BE-NL:
# cyclestreet=* | Local preset for countries "BE", "NL"
label: Cyclestreet
options:
# cyclestreet=undefined
undefined: 'No'
# cyclestreet=yes
'yes': 'Yes'
terms: '[translate with synonyms or related terms for ''Cyclestreet'', separated by commas]'
cycleway:
# cycleway:left=*, cycleway:right=*
label: Bike Lanes
Expand Down
⚡