Skip to content

Create crossing/markings-BG.json#891

Merged
tyrasd merged 19 commits intoopenstreetmap:mainfrom
Dimitar5555:patch-1
May 11, 2023
Merged

Create crossing/markings-BG.json#891
tyrasd merged 19 commits intoopenstreetmap:mainfrom
Dimitar5555:patch-1

Conversation

@Dimitar5555
Copy link
Copy Markdown
Contributor

Resolves #876

@github-actions
Copy link
Copy Markdown

🍱 Preview the tagging presets of this pull request here: https://pr-891--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@Dimitar5555
Copy link
Copy Markdown
Contributor Author

@tyrasd Any ideas why it's not working correctly? The screenshot is from a crossing in Bulgaria.

image

@Dimitar5555
Copy link
Copy Markdown
Contributor Author

At least the field shows now. Not sure why it's not the right one though..
image

@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented May 5, 2023

Sorry for the late reply, but the issue you're seeing is caused by the regional field not specifying "autoSuggestions": false. In the autoSuggestions=true case (which is the default), iD will query taginfo for popular values of the tag and show those in addition to the supplied options.

@Dimitar5555
Copy link
Copy Markdown
Contributor Author

Thanks, it is working as intended now.
image

tyrasd added a commit to openstreetmap/iD that referenced this pull request May 11, 2023
this fixes where tag values of fields with referenced strings can become corrupted when the sub-field has restricted `options`, and an unavailable option is entered manually into the field.

important for openstreetmap/id-tagging-schema#891
tyrasd added a commit to openstreetmap/iD that referenced this pull request May 11, 2023
this fixes where tag values of fields with referenced strings can become corrupted when the sub-field has restricted `options`, and an unavailable option is entered manually into the field.

important for openstreetmap/id-tagging-schema#891
@tyrasd tyrasd merged commit bc25be1 into openstreetmap:main May 11, 2023
tyrasd added a commit that referenced this pull request May 11, 2023
@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented May 11, 2023

Thanks!

PS: I noticed that the new regional field was not included in the */traffic_signals.json files. I assume that was an oversight, so I just added it in 57fe16f

@Dimitar5555 Dimitar5555 deleted the patch-1 branch May 11, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide irrelevant crossing:markings values

2 participants