Add Warning Sign presets

[arch0345]

This PR adds presets for both values of hazard=* listed in the approved proposal as well as some of the top values with an article on the wiki listed on Taginfo.

Adds presets for:

• boundary=hazard (moved to Add Hazardous Area preset #952)
• traffic_sign=hazard
  • hazard=animal_crossing
  • hazard=bump
  • hazard=children
  • hazard=curve
  • hazard=curves
  • hazard=cyclists
  • hazard=dangerous_junction
  • hazard=dip
  • hazard=emergency_vehicles
  • hazard=falling_rocks
  • hazard=flooding
  • hazard=fog
  • hazard=ground_clearance
  • hazard=horse_riders
  • hazard=ice
  • hazard=landslide
  • hazard=loose_gravel
  • hazard=pedestrians
  • hazard=queues_likely
  • hazard=road_narrows
  • hazard=roundabout
  • hazard=school_zone
  • hazard=slippery
  • hazard=traffic_signals
  • hazard=turn
  • hazard=turns

Adds fields for:

• curve=*
• curves=*
• hazard=*
• hazard:animal=*

Also changed the name for the military=danger_area preset to "Military Danger Area" (moved to #952)

[github-actions]

🍱 Preview the tagging presets of this pull request here: https://pr-928--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

[1ec5]

The preset names should also be localizable string options for the Traffic Sign field.

These presets understandably focus on the generic values, which apply internationally. But we should probably also add presets for each country’s standard warning signs that set traffic_sign to a sign code; otherwise, we might inadvertently nudge mappers to replace the specific values with a generic value that has a nice icon, resulting in dataloss.

[Dimitar5555]

But we should probably also add presets for each country’s standard warning signs that set traffic_sign to a sign code; otherwise, we might inadvertently nudge mappers to replace the specific values with a generic value that has a nice icon, resulting in dataloss.

Related discussion: osmlab/name-suggestion-index#8225

[1ec5]

These presets understandably focus on the generic values, which apply internationally. But we should probably also add presets for each country’s standard warning signs that set traffic_sign to a sign code; otherwise, we might inadvertently nudge mappers to replace the specific values with a generic value that has a nice icon, resulting in dataloss.

I think this is a very real possibility in some regions, such as Central Europe and Scandinavia, where traffic_sign has been mapped to great detail. At the same time, the code-based traffic_sign syntax as documented on the wiki is unsuitable for proper editor support. An alternative syntax is in use regionally that would be much more amenable to software support, but the wiki doesn’t really acknowledge this alternative: #11 (comment).

[arch0345]

These presets understandably focus on the generic values, which apply internationally. But we should probably also add presets for each country’s standard warning signs that set traffic_sign to a sign code; otherwise, we might inadvertently nudge mappers to replace the specific values with a generic value that has a nice icon, resulting in dataloss.

I'll separate addition of boundary=hazard into its own PR so that #916 can be resolved before this issue is addressed.

[matkoniecz]

@arch0345 arch0345 marked this pull request as draft July 8, 2023 00:40

do you have any plans to continue with this PR?

[matkoniecz]

I will close it as an abandoned PR

[matkoniecz]

it can reopened in this PR or send as a new one if it would be an improvement

maybe it is possible to split it into smaller, more manageable parts