Add translatable strings to social_facility:for field#934
Merged
tyrasd merged 14 commits intoopenstreetmap:mainfrom Jun 30, 2023
Merged
Add translatable strings to social_facility:for field#934tyrasd merged 14 commits intoopenstreetmap:mainfrom
tyrasd merged 14 commits intoopenstreetmap:mainfrom
Conversation
Approved values only
|
🍱 Preview the tagging presets of this pull request here: https://pr-934--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
tyrasd
requested changes
Jun 27, 2023
Member
There was a problem hiding this comment.
I'd use the plural form for the values and be a bit more specific in some cases. See inline suggestions below.
Also, could you please add the missing values from the list in the wiki, i.e. dementia, displaced, terminally_ill, unemployed, veteran and woman. Yes, these are relatively rare, but in my opinion they do make sense to be offered.
//edit: PS:
Approved values only
In this case, I would go with the list on the wiki page, as the tag has clearly evolved slightly after the proposal phase. E.g. the value under_privileged is now practically unused compared to underprivileged.
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
tyrasd
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approved values only