Presets for common taxi vehicles found in developing regions#946
Merged
tyrasd merged 24 commits intoopenstreetmap:mainfrom Jul 21, 2023
Merged
Presets for common taxi vehicles found in developing regions#946tyrasd merged 24 commits intoopenstreetmap:mainfrom
tyrasd merged 24 commits intoopenstreetmap:mainfrom
Conversation
Add preset for auto_rickshaw.
Create an easy preset for amenity=taxi+taxi_vehicle=cycle_rickshaw, for cycle rickshaw stands, popular in many developing countries.
Add an easy preset for amenity=taxi+taxi_vehicle=motorcycle combo, for taxi stands of this type, found in many developing regions.
Remove extra comma.
|
🍱 Preview the tagging presets of this pull request here: https://pr-946--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
Move "taxi_vehicle" field to tags.
Move "taxi_vehicle" field to tags section.
Move taxi_vehicle field to tags section.
Add field "taxi_vehicle", to help indicate the type of vehicle used by taxis from this stand.
Create field taxi_vehicle.json, for use in amenity=taxi, to identify the type of vehicle to expect from a taxi stand.
Fix quotation marks.
Remove extra space
Add more common terms, as examples.
Switch icon from "fas-people-pulling", to "roentgen-bus_stop_sign".
Change term entry to alias, "tricycle terminal", based on user feedback.
Add "Pedicab Terminal" as alias, from user suggestion.
tyrasd
added
new-field
tyrasd
reviewed
Jul 10, 2023
Member
There was a problem hiding this comment.
The usage of this tag is currently still low, but it seems to be new and rapidly becoming more popular.
One question which came to my mind is: how common is it to see stands with mixed vehicles (e.g. auto_rickshaw and motorcycle, etc.)? If they are somewhat common, the field could be changed into a semiCombo type to support that as well.
I see that you reduced the number of included fields in the presets for the sub-types. Would it not make sense to keep these consistent with the "main" taxi preset?
See a few additional comments/suggestions below.
Revise field type to "semicombo", and separate description text from options.
move "taxi_vehicle" to moreFields section.
Add "bajaj" Co-authored-by: Martin Raifer <martin@raifer.tech>
Fix typo in type to "semiCombo"
Move help tips from description to title section.
Retain similar fields from taxi.json for consistency.
Retain similar fields from taxi.json for consistency.
Retain similar fields from taxi.json for consistency.
Member
|
@govvin is this ready to be reviewed now? |
Contributor
Author
tyrasd
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the following preset combos for taxis, by
taxi_vehicletypes.amenity=taxi+taxi_vehicle=auto_rickshawamenity=taxi+taxi_vehicle=cycle_rickshawamenity=taxi+taxi_vehicle=motorcycletaxi_vehicle.jsonfieldtaxi_vehicleThis is my first time to do something like this, adding a preset for a combination of tags. Icons could be better.
Is this how it's done?