-
Notifications
You must be signed in to change notification settings - Fork 252
Add preset stolperstein with deprecations and memorial:addr field
#964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7f4027c
Add preset `stolperstein` with deprecations and `memorial:addr` field
tordans 9614d42
Preset "stolperstein": Update wikidata
tordans eaca7fa
Field "memorial:addr" fix missing key
tordans 74b934c
Fix "stolperstein" deprecation
tordans 391bffe
Preset "stolperstein": update field/moreField
tordans 8e90f99
Preset/stolperstein: Make preset EU only
tordans 4721b90
Preset/stolperstein: Update address fields
tordans ebc1099
Preset/stolperstein: Remove memorial:addr field
tordans 0fe03d7
add secondary memorial:addr:* field for when the subtag schema is used
tyrasd 9fbb9c2
Preset/stolpersteine: User `*:street` instead of `housenumber` to tri…
tordans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "type": "address", | ||
| "key": "addr", | ||
| "keys": [ | ||
| "memorial:addr:city", | ||
| "memorial:addr:street", | ||
| "memorial:addr:postcode", | ||
| "memorial:addr:housenumber" | ||
| ], | ||
| "label": "Nearest building address" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "icon": "temaki-plaque", | ||
| "fields": [ | ||
| "name", | ||
| "inscription", | ||
| "wikidata" | ||
| ], | ||
| "moreFields": [ | ||
| "memorial/addr", | ||
| "address", | ||
| "subject/wikidata", | ||
| "image", | ||
| "wikimedia_commons", | ||
| "website" | ||
| ], | ||
| "geometry": [ | ||
| "point", | ||
| "vertex" | ||
| ], | ||
| "tags": { | ||
| "historic": "memorial", | ||
| "memorial": "stolperstein" | ||
| }, | ||
| "name": "Memorial Plaque Stolperstein" | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.