Skip to content

preset traffic_sign=maxspeed: Use direction icon same as other traffic_sign presets#968

Merged
tyrasd merged 1 commit intoopenstreetmap:mainfrom
tordans:maxspeed-icon
Aug 3, 2023
Merged

preset traffic_sign=maxspeed: Use direction icon same as other traffic_sign presets#968
tyrasd merged 1 commit intoopenstreetmap:mainfrom
tordans:maxspeed-icon

Conversation

@tordans
Copy link
Copy Markdown
Collaborator

@tordans tordans commented Jul 29, 2023

The preset for traffic_sign=maxspeed was the only one in the traffic_sign preset list that used the maki square icon, which is the default "no icon" icon (at least in GoMap).

This PR changes the icon to use fas-directions which is what the other generic icons use.

FYI, the square Icon is on the maxspeed preset since the start of this repo.

Previous:

Bildschirm­foto 2023-07-29 um 13 15 04

@github-actions
Copy link
Copy Markdown

🍱 Preview the tagging presets of this pull request here: https://pr-968--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@tyrasd tyrasd added the new-icon label Aug 3, 2023
@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Aug 3, 2023

yeah, the icon was like that from the very first version of the preset in iD (see openstreetmap/iD@cd8be8b). I assume this was chosen because it somewhat resembles the shape of speed limit signs found in the US, Canada and Liberia. I guess we could have a regional copy of the preset with the square icon for these countries… 🤔 //edit: done in 5c68954

@tyrasd tyrasd merged commit 9a3e8b3 into openstreetmap:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants