Skip to content

[demo] add secondary memorial:addr:* field for when the subtag schema is used#971

Closed
tyrasd wants to merge 1 commit intoopenstreetmap:stolpersteinefrom
tyrasd:stolpersteine
Closed

[demo] add secondary memorial:addr:* field for when the subtag schema is used#971
tyrasd wants to merge 1 commit intoopenstreetmap:stolpersteinefrom
tyrasd:stolpersteine

Conversation

@tyrasd
Copy link
Copy Markdown
Member

@tyrasd tyrasd commented Aug 3, 2023

for #964 (this PR is not meant to be merged, it's just to get the demo/preview of the below mentioned functionality)

I tried adding both variants and make it that the UI picks the right one based on existing tags. However, the type:address does not allow other tags that addr:* (it does not automatically use a different prefix), so that was a dead end.

Something like this should do the trick. It's not 100% waterproof, as it relies on the memorial:addr:housenumber tag to determine which field to display (there might be the case where only be a memorial:addr:housename exists), but except for that it seems to work fine.

@tyrasd tyrasd marked this pull request as draft August 3, 2023 16:42
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 3, 2023

🍱 Preview the tagging presets of this pull request here: https://pr-971--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Aug 17, 2023

Thanks a lot @tyrasd I merged this into #964. This PR can be closed IMO.

@tyrasd tyrasd closed this Aug 25, 2023
@tyrasd tyrasd added the wontfix This will not be worked on label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants