Skip to content

Add translatable strings to "marker" field#973

Closed
kjonosm wants to merge 4 commits intoopenstreetmap:mainfrom
kjonosm:main-2
Closed

Add translatable strings to "marker" field#973
kjonosm wants to merge 4 commits intoopenstreetmap:mainfrom
kjonosm:main-2

Conversation

@kjonosm
Copy link
Copy Markdown
Contributor

@kjonosm kjonosm commented Aug 8, 2023

No description provided.

@github-actions
Copy link
Copy Markdown

🍱 Preview the tagging presets of this pull request here: https://pr-973--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@tyrasd tyrasd added new-value adds value(s) to existing field considering May be rejected or approved, decision was not taken yet. Rejection is more likely than typical. labels Aug 10, 2023
@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Aug 10, 2023

I think at least some of the value labels are not really intuitive… for example Aerial was not quite clear to me without reading the wiki page. It could be a good idea to use the title/description syntax here, to add some additional information to these values:

        
        "options": {
            "aerial": {
                "title": "Aerial",
                "description": "Designed to be seen by aerial inspection"
            },
            

What do you think?

@kjonosm
Copy link
Copy Markdown
Contributor Author

kjonosm commented Aug 12, 2023

@tyrasd
I added short descriptions based on OSM wiki.
Feel free to adjust the wording...

Comment thread data/fields/marker.json
Comment thread data/fields/marker.json
@1ec5
Copy link
Copy Markdown
Contributor

1ec5 commented Aug 12, 2023

I guess it’s fine to omit marker=paddle. As far as we know so far, it’s only being used in one country, although in reality it’s being used in very large numbers.

@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Aug 13, 2023

merged as c0bfb28

@tyrasd tyrasd closed this Aug 13, 2023
@tyrasd tyrasd removed the considering May be rejected or approved, decision was not taken yet. Rejection is more likely than typical. label Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-value adds value(s) to existing field

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants