Take entrances into account for routing start and end points#7017
Open
lonvia wants to merge 1 commit intoopenstreetmap:masterfrom
Open
Take entrances into account for routing start and end points#7017lonvia wants to merge 1 commit intoopenstreetmap:masterfrom
lonvia wants to merge 1 commit intoopenstreetmap:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Nominatim has been able for a while to return entrances of buildings and similiar way area features. This PR introduces entrance-awareness to the router UI: when searching for a place for the routing start and end points, it requests entrances from Nominatim. If suitable entrances (
mainoryes) come back, their location will be used for routing instead of the centroid of the feature.I've kept the implementation fairly simple for now. Nominatim returns the full set of tags for each entrance. So one could do something much more elaborate by looking into level and access tags. For example, it would be nice to choose the right entrance for the choose mode of transportation. Right now I consider this just a starting point for creating a positive feedback loop between improved entrance tagging and the OSM UI.
Warning: the Nominatim servers currently only have entrances edited in the last six months but a reimport for all servers is imminent. If you want to test this locally, use poldi which is newly imported.
How has this been tested?
Here is what a route from Berlin Airport to the center looks at the starting point before the change:
And here the same thing afterwards.
No new unit tests added, sorry.