This repository was archived by the owner on Jan 18, 2023. It is now read-only.
#112 Added check to ensure we don't unsubscribe when disconnected#114
Open
wolfenrain wants to merge 2 commits intoopentok:mainfrom
Open
#112 Added check to ensure we don't unsubscribe when disconnected#114wolfenrain wants to merge 2 commits intoopentok:mainfrom
wolfenrain wants to merge 2 commits intoopentok:mainfrom
Conversation
|
@wolfenrain I'm happy to store a disconnected state, but we should use the events such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing checklist
Solves issue(s)
#112
Explanation
When disconnecting from session, there are still events being emitted, and depending on which one comes first, it will try to unsubscribe a subscriber while the Session doesn't know the subscriber. And that causes crashes.
I added a simple check to prevent that, it is a different boolean then the
sessionConnectedboolean because that one gets sets within those events, so it wouldnt have much influences. This way it does not break any of the current code. (also added asubscriberCollection.removebecause otherwise it will try to remove subscriber that doesnt exist anymore)