This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Improvement in the getPosition method so that the video obeys the siz…#125
Open
samurodrigo wants to merge 1 commit intoopentok:mainfrom
Open
Improvement in the getPosition method so that the video obeys the siz…#125samurodrigo wants to merge 1 commit intoopentok:mainfrom
samurodrigo wants to merge 1 commit intoopentok:mainfrom
Conversation
…e and position of the div that contains it
|
@samurodrigo Thanks for the PR. It looks like you modified the |
Author
|
Hi @msach22, thanks for the review. I made another pull request right now ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e and position of the div that contains it
This commit solves the issue #124