Add xattention test case by mangguo321 · Pull Request #3676 · openvinotoolkit/openvino.genai

mangguo321 · 2026-04-10T02:49:44Z

Description

Add xattention test case.
Add get_scheduler_config() to expose the effective scheduler configuration, and assert xattention behavior in test when the configuration does not match expectations.

Checklist:

This PR follows GenAI Contributing guidelines.
Tests have been updated or added to cover the new code.
This PR fully addresses the ticket.
I have made corresponding changes to the documentation.

Copilot

Pull request overview

Adds a new Python E2E test to validate that enabling SparseAttentionMode.XATTENTION does not significantly degrade generation similarity versus the non-sparse baseline, and wires this test into the Linux CI matrix for continuous batching.

Changes:

Added test_xattention.py to compare similarity between xattention-enabled and disabled ContinuousBatchingPipeline runs.
Added a new Linux CI step to execute the xattention test under the continuous batching affected-components gate.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
tests/python_tests/test_xattention.py	New similarity-based regression test for XAttention vs baseline.
.github/workflows/linux.yml	Runs the new xattention test as an additional Cacheopt E2E CI step.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

…ssert xattention in test

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

rkazants

Please provide proper PR description. The PR title does not reflect a real source changes. Here you seem to add get_schedule_config(). Please explain in the description why it is needed.

mangguo321 · 2026-04-20T01:40:23Z

Please provide proper PR description. The PR title does not reflect a real source changes. Here you seem to add get_schedule_config(). Please explain in the description why it is needed.

Updated the description. Thanks! @rkazants

Copilot AI review requested due to automatic review settings April 10, 2026 02:49

github-actions Bot added category: GHA CI based on Github actions category: GGUF GGUF file reader labels Apr 10, 2026

Copilot started reviewing on behalf of mangguo321 April 10, 2026 02:50 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Comment thread tests/python_tests/test_xattention.py Outdated

Comment thread .github/workflows/linux.yml Outdated

Copilot AI review requested due to automatic review settings April 10, 2026 05:53

mangguo321 marked this pull request as ready for review April 10, 2026 05:54

mangguo321 requested review from akashchi and sgonorov as code owners April 10, 2026 05:54

Copilot started reviewing on behalf of mangguo321 April 10, 2026 05:54 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Comment thread tests/python_tests/test_sparse_prefill.py

Comment thread tests/python_tests/test_sparse_prefill.py

Wovchena reviewed Apr 10, 2026

View reviewed changes

Comment thread tests/python_tests/test_xattention.py Outdated

Wovchena requested a review from l-bat April 10, 2026 07:05

mangguo321 and others added 3 commits April 10, 2026 18:57

Add xattention test case

335fe64

Update tests/python_tests/test_xattention.py

a9038fd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix review comments

1f09eeb

Copilot AI review requested due to automatic review settings April 13, 2026 02:49

mangguo321 requested review from as-suvorov and popovaan as code owners April 13, 2026 02:49

github-actions Bot added category: continuous batching Continuous batching category: Python API Python API for GenAI category: CPP API Changes in GenAI C++ public headers labels Apr 13, 2026

Copilot started reviewing on behalf of mangguo321 April 13, 2026 02:50 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread src/cpp/src/continuous_batching/pipeline_base.hpp Outdated

Copilot AI review requested due to automatic review settings April 13, 2026 05:47

Copilot started reviewing on behalf of mangguo321 April 13, 2026 05:48 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread .github/workflows/linux.yml Outdated

l-bat reviewed Apr 13, 2026

View reviewed changes

Comment thread tests/python_tests/test_sparse_prefill.py

Comment thread tests/python_tests/test_xattention.py Outdated

Comment thread tests/python_tests/test_sparse_prefill.py

Comment thread src/cpp/src/continuous_batching/pipeline.cpp

mangguo321 and others added 2 commits April 13, 2026 19:24

Add get_scheduler_config() to expose effective scheduler config and a…

f73eb10

…ssert xattention in test

Fix review comment

1054b99

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix CI failure

34d4bc6

sgonorov requested changes Apr 14, 2026

View reviewed changes

Comment thread .github/workflows/linux.yml Outdated

Comment thread .github/workflows/linux.yml Outdated

Comment thread tests/python_tests/test_sparse_prefill.py

Comment thread tests/python_tests/test_xattention.py Outdated

Copilot AI review requested due to automatic review settings April 14, 2026 05:40

Copilot started reviewing on behalf of mangguo321 April 14, 2026 05:41 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread src/cpp/include/openvino/genai/continuous_batching_pipeline.hpp

Fix review comments

b73dc0c

l-bat approved these changes Apr 16, 2026

View reviewed changes

Change file name to test_sparse_prefill.py

c3090d6

rkazants requested changes Apr 17, 2026

View reviewed changes

Conversation

mangguo321 commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

rkazants left a comment

Choose a reason for hiding this comment

Uh oh!

mangguo321 commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mangguo321 commented Apr 10, 2026 •

edited

Loading