-
Notifications
You must be signed in to change notification settings - Fork 391
[VLM] Enable Qwen3.5 (SDPA only) #3717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
2a6ab4b
04c14ad
7b02b27
ec3d817
3c5c25c
58d1518
8e12bd5
f89b4fa
437458c
8d54ae9
e3d1fe4
befa0f8
0295a10
83cf836
5bc0944
77f7f5f
83dcbd0
cf92773
03c9e04
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -753,9 +753,12 @@ class VLMPipeline::VLMPipelineImpl : public VLMPipelineBase{ | |
| }; | ||
|
|
||
| // TODO: remove it when GEMMA3 ticket-171180 is fixed | ||
| // TODO: remove Qwen3.5 limitation once ticket-183791 is fixed | ||
| bool requires_sdpa(const std::filesystem::path& models_dir) { | ||
| auto vlm_config = utils::from_config_json_if_exists<VLMConfig>(models_dir, "config.json"); | ||
| return vlm_config.model_type == VLMModelType::GEMMA3; | ||
| return vlm_config.model_type == VLMModelType::GEMMA3 | ||
| || vlm_config.model_type == VLMModelType::QWEN3_5 | ||
| || vlm_config.model_type == VLMModelType::QWEN3_5_MOE; | ||
|
Comment on lines
755
to
+761
|
||
| } | ||
|
Comment on lines
755
to
762
|
||
|
|
||
| VLMPipeline::VLMPipeline( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces support for an additional 3D position_ids layout (dim0=4 for text+THW, used by Qwen3.5). Please add/extend automated coverage (e.g., in tests/python_tests/test_vlm_pipeline.py) to validate both the new dim0=4 behavior and that existing dim0=3 models are unaffected, including at least one tiny-random Qwen3.5 export path as per project testing guidelines.