Skip to content

[ci] Added Django 6.0 to test matrix#353

Merged
nemesifier merged 1 commit intomasterfrom
django6
May 4, 2026
Merged

[ci] Added Django 6.0 to test matrix#353
nemesifier merged 1 commit intomasterfrom
django6

Conversation

@nemesifier
Copy link
Copy Markdown
Member

Added Django 6.0 to test matrix.

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • N/A I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

@nemesifier nemesifier self-assigned this May 3, 2026
@nemesifier nemesifier added the github_actions Pull requests that update GitHub Actions code label May 3, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 62f4155c-6aec-4849-a222-758d935b4307

📥 Commits

Reviewing files that changed from the base of the PR and between a4c3052 and 4a4c5fd.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • README.rst
  • tox.ini
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Python==3.10 | py310-django52-djangorestframework315
  • GitHub Check: Python==3.11 | py311-django51-djangorestframework315
  • GitHub Check: Python==3.13 | py313-django50-djangorestframework315
  • GitHub Check: Python==3.9 | py39-django42-djangorestframework314
  • GitHub Check: Python==3.10 | py310-django50-djangorestframework315
  • GitHub Check: Python==3.10 | py310-django42-djangorestframework314
  • GitHub Check: Python==3.11 | py311-django50-djangorestframework315
  • GitHub Check: Kilo Code Review
  • GitHub Check: Analyze (python)
  • GitHub Check: Analyze (actions)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{md,rst,txt,adoc}

📄 CodeRabbit inference engine (Custom checks)

**/*.{md,rst,txt,adoc}: Changes: If the change affects documented behavior, update the documentation to reflect the new behavior
Features: Update documentation to mention the new feature; use a new documentation section or page if the feature is heavily UI-related

Files:

  • README.rst
**/*.{md,rst,txt,adoc,js,ts,jsx,tsx,py,java,cs,go,rb,php,cpp,c,h,rs}

📄 CodeRabbit inference engine (Custom checks)

General: Flag outdated or incorrect documentation, comments, or docstrings

Files:

  • README.rst
🔇 Additional comments (3)
tox.ini (1)

8-8: Django 6.0 tox factors are correctly wired.

Line 8 and Line 26 are consistent: the new django60 env factors are defined and mapped to Django~=6.0.0, matching the intended CI expansion.

Also applies to: 26-26

.github/workflows/ci.yml (1)

102-105: CI matrix extension is consistent with tox configuration.

Line 102 through Line 105 correctly add the Django 6.0 jobs for Python 3.12/3.13, and the TOXENV values match the tox environments.

README.rst (1)

44-44: Compatibility table update is aligned with the new Django 6.0 support.

Line 44 correctly reflects the documented compatibility expansion introduced by this PR.

As per coding guidelines, "If the change affects documented behavior, update the documentation to reflect the new behavior".


📝 Walkthrough

Walkthrough

The pull request extends testing and documentation coverage for Django 6.0 compatibility. The CI workflow test matrix, tox configuration, and README compatibility table are updated to include Python 3.12 and 3.13 environments with Django 6.0 and DRF 3.17. The changes add corresponding dependency selectors and test environments while maintaining existing CI logic and workflow steps unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required [type] format with 'ci' type and clearly describes the main change of adding Django 6.0 to the test matrix.
Description check ✅ Passed The description covers main changes and checklist items, though it lacks a section for 'Reference to Existing Issue' and mentions N/A for tests without clear explanation.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Bug Fixes ✅ Passed PR is a CI configuration update to add Django 6.0 to the test matrix, not a bug fix. This falls under the valid exception for GitHub Actions workflow changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch django6

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented May 3, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • .github/workflows/ci.yml - Adds Django 6.0 test matrix entries for Python 3.12 and 3.13
  • tox.ini - Adds django60 environment and dependency mapping
  • README.rst - Updates compatibility table to reflect Django 4.2 to 6.0 support

Reviewed by kimi-k2.5 · 83,374 tokens

@github-project-automation github-project-automation Bot moved this from In progress to Reviewer approved in OpenWISP Priorities for next releases May 3, 2026
@nemesifier nemesifier merged commit 4a4c5fd into master May 4, 2026
43 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in OpenWISP Priorities for next releases May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Development

Successfully merging this pull request may close these issues.

2 participants