[bug] API endpoints are failing with "Organization not found, `organization_field` not implemented correctly."

[nemesifier]

The following API endpoints:

• /api/v1/ipam/ip-address/<id>/
• /api/v1/ipam/subnet/<id>/

Are failing when using the latest version of openwisp-users, with the error:

Organization not found, `organization_field` not implemented correctly.

However, the bug is not showing in tests, so I'm puzzled by this and I would like to know if anyone can confirm this.

PS: it may happen when using non super users (is_superuser=False).

Similar issues already resolved in other modules:

openwisp/openwisp-controller#1093
openwisp/openwisp-controller#1110

[aagmanbhatt]

These end points have changed to :
/api/v1/ipam/ip-address/<id>/
/api/v1/ipam/subnet/<id>/

and I am unable to replicate this error

[DavidMeu]

Reproduced in my end:
Created a subnet with empty organization field (null).
curl -X POST "<URL>/api/v1/ipam/subnet/" -H "Authorization: Bearer some token" -d "subnet=10.0.0.0/24&organization="
And tried deleting it:
curl -X DELETE "<URL>/api/v1/ipam/subnet/6d003f5a-df3d-4a57-b136-78f97a3e48b3/" -H "Authorization: Bearer some token"

And got:
AttributeError: Organization not found, organization_field not implemented correctly.

*master branch
*When applying the creation+deletion via the admin site it is ok

Trace:

  File "\venv\lib\site-packages\openwisp_users\api\permiss
ions.py", line 13, in has_object_permission
    organization = self.get_object_organization(view, obj)
  File "\venv\lib\site-packages\openwisp_users\api\permiss
ions.py", line 26, in get_object_organization
    raise AttributeError(

Exception Type: AttributeError at /api/v1/ipam/subnet/98781c63-c6dd-4375-a783-1609a90740df/
Exception Value: Organization not found, `organization_field` not implemented correctly.

@aagman945 on what version you tried replicate this issue?

[praptisharma28]

When I tried to reproduce this error:

(venv-ipam) prapti@prapti:~/Desktop/openwisp/openwisp-ipam/tests$ curl -v -X POST "http://127.0.0.1:8000/api/v1/ipam/subnet/" \27.0.0.1:8000/api/v1/ipam/subnet/" \
     -H "Authorization: Bearer 961b450e4f327b661e86a89937c81a0ec5abfc9d" \
     -H "Content-Type: application/x-www-form-urlencoded" \
     -d "name=Test Subnet&subnet=10.0.0.0/24&organization="
Note: Unnecessary use of -X or --request, POST is already inferred.
*   Trying 127.0.0.1:8000...
* Connected to 127.0.0.1 (127.0.0.1) port 8000 (#0)
> POST /api/v1/ipam/subnet/ HTTP/1.1
> Host: 127.0.0.1:8000
> User-Agent: curl/7.81.0
> Accept: */*
> Authorization: Bearer 961b450e4f327b661e86a89937c81a0ec5abfc9d
> Content-Type: application/x-www-form-urlencoded
> Content-Length: 49
> 
* Mark bundle as not supporting multiuse
< HTTP/1.1 201 Created
< Date: Fri, 01 Nov 2024 14:12:28 GMT
< Server: WSGIServer/0.2 CPython/3.10.12
< Content-Type: application/json
< Vary: Accept
< Allow: GET, POST, HEAD, OPTIONS
< X-Frame-Options: DENY
< Content-Length: 228
< X-Content-Type-Options: nosniff
< Referrer-Policy: same-origin
< Cross-Origin-Opener-Policy: same-origin
< 
* Connection #0 to host 127.0.0.1 left intact
{"id":"533bb1c1-02d1-4542-8467-8bd963ab3eb5","created":"2024-11-01T14:12:28.621520Z","modified":"2024-11-01T14:12:28.621520Z","name":"Test Subnet","subnet":"10.0.0.0/24","description":"","organization":null,"master_subnet":null}(venv-ipam) prapti@prapti:~/Desktop/openwisp/openwisp-ipam/tests$ curl -v -X DELETE "http://127.0.0.1:8000/api/v1/ipam/subnet/533bb1c1-02d1-4542-8467-8bd963ab3eb5/" \                              curl -v -X DELETE "http://127.0.0.1:8000/api/v1/ipam/subnet/533bb1c1-02d1-4542-8467-8bd963ab3eb5/" \
     -H "Authorization: Bearer 961b450e4f327b661e86a89937c81a0ec5abfc9d"
*   Trying 127.0.0.1:8000...
* Connected to 127.0.0.1 (127.0.0.1) port 8000 (#0)
> DELETE /api/v1/ipam/subnet/533bb1c1-02d1-4542-8467-8bd963ab3eb5/ HTTP/1.1
> Host: 127.0.0.1:8000
> User-Agent: curl/7.81.0
> Accept: */*
> Authorization: Bearer 961b450e4f327b661e86a89937c81a0ec5abfc9d
> 
* Mark bundle as not supporting multiuse
< HTTP/1.1 204 No Content
< Date: Fri, 01 Nov 2024 14:12:53 GMT
< Server: WSGIServer/0.2 CPython/3.10.12
< Vary: Accept, Cookie
< Allow: GET, PUT, PATCH, DELETE, HEAD, OPTIONS
< X-Frame-Options: DENY
< Content-Length: 0
< X-Content-Type-Options: nosniff
< Referrer-Policy: same-origin
< Cross-Origin-Opener-Policy: same-origin
< 
* Connection #0 to host 127.0.0.1 left intact
(venv-ipam) prapti@prapti:~/Desktop/openwisp/openwisp-ipam/tests$ 

I was able to delete it successfully.
Can we confirm this issue ? @nemesifier @pandafy

[Tanishquppal220]

I would like to work on this

[nemesifier]

I would like to work on this

@Tanishquppal220 See similar issues recently solved elsewhere:

openwisp/openwisp-controller#1093
openwisp/openwisp-controller#1110

[Tanishquppal220]

I tried re-creating this bug . but i was not able to reproduce it . can you please provide more information or check on your end once like what config of user ,organization and subnet is causing the bug.