[admin] Add "goto" in subnet

[purhan]

This is slightly different than the solution proposed in the issue discussions but I hope this one works out better 😄

Preview

Closes #39

[TravisBuddy]

Travis tests have failed

Hey @purhan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

4th Build

View build log

./run-qa-checks

Check JavaScript Linting

./openwisp_ipam/static/openwisp-ipam/js/ip-request.js is OK.

./openwisp_ipam/static/openwisp-ipam/js/subnet.js
 #1 Expected ';' and instead saw '}'.
    $(this).toggle($(this).text().toLowerCase().indexOf(searchQuery) > -1) // Line 65, Pos 87
travis_time:end:065f3678:start=1604320419605081272,finish=1604320419720555312,duration=115474040,event=script

6th Build

View build log

./run-qa-checks

Check JavaScript Linting

./openwisp_ipam/static/openwisp-ipam/js/ip-request.js is OK.

./openwisp_ipam/static/openwisp-ipam/js/subnet.js
 #1 Expected ';' and instead saw '}'.
    $(this).toggle($(this).text().toLowerCase().indexOf(searchQuery) > -1) // Line 65, Pos 87

TravisBuddy Request Identifier: a18b1fe0-1d0a-11eb-916b-c54e98fd930e

[atb00ker]

this doesn't search within the pages that have not yet been loaded.

Ideally, the search should filter all the IPs in the subnet. Loaded in frontend or not.

[purhan]

@atb00ker What would be the proper approach? The API's response is paginated so I'd still have to cycle through all the pages to search for matching queries. Wouldn't that be too slow?

[atb00ker]

@purhan
When user searches for something and presses enter key. A request is send to the server, which would send filtered records in turn.
That way you don't have to cycle through records in the frontend but the server would do that for you. 😄

What do you think? 😄

[purhan]

I tried parsing the search queries from the backend with some successful results but it'd still be very slow to parse results for larger search inputs. I think it's not a good idea to use search and filter here, so it's best to just implement the go-to approach as suggested in the original issue (i.e. jump to the search query in the original list itself) otherwise I'd likely abandon this task 😄. What do you think?

[purhan]

@atb00ker this is what it looks like now. Please take a look.

[TravisBuddy]

Travis tests have failed

Hey @purhan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

6th Build

View build log

./run-qa-checks

Check JavaScript Linting

./openwisp_ipam/static/openwisp-ipam/js/ip-request.js is OK.

./openwisp_ipam/static/openwisp-ipam/js/subnet.js
 #1 'async' was used before it was defined.
    async function validateIp(ip_address) { // Line 62, Pos 5
 #2 Expected ';' and instead saw 'function'.
    async function validateIp(ip_address) { // Line 62, Pos 10
 #3 Expected 'function' at column 5, not column 11.
    async function validateIp(ip_address) { // Line 62, Pos 11
 #4 Expected '{' and instead saw 'return'.
    if (ip_address === '') return true; // Line 63, Pos 32
 #5 Stopping. (38% scanned).
     // Line 63, Pos 32

TravisBuddy Request Identifier: 7f6ff8e0-1fad-11eb-bd2e-17a8c440c3de

[nemesifier]

Thanks a lot @purhan! I haven't had time to test it yet but will leave some comments on the code now.

[TravisBuddy]

Travis tests have failed

Hey @purhan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

6th Build

View build log

./run-qa-checks

Check JavaScript Linting

./openwisp_ipam/static/openwisp-ipam/js/ip-request.js is OK.

./openwisp_ipam/static/openwisp-ipam/js/subnet.js
 #1 'isValid' was used before it was defined.
    validateIp(input, (isValid) => { // Line 81, Pos 28
 #2 Unexpected '('.
    validateIp(input, (isValid) => { // Line 81, Pos 27
 #3 Missing space between '=' and '>'.
    validateIp(input, (isValid) => { // Line 81, Pos 38
 #4 Unexpected '>'.
    validateIp(input, (isValid) => { // Line 81, Pos 38
 #5 Stopping. (49% scanned).
     // Line 81, Pos 40

TravisBuddy Request Identifier: 3d3215f0-2005-11eb-9dab-419bf2960c30

[coveralls]

Pull Request Test Coverage Report for Build 228

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 99.336%

---

Totals
Change from base Build 214:	0.0%
Covered Lines:	598
Relevant Lines:	602

---

💛 - Coveralls

[TravisBuddy]

Travis tests have failed

Hey @purhan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

6th Build

View build log

./run-qa-checks

Check JavaScript Linting

./openwisp_ipam/static/openwisp-ipam/js/ip-request.js is OK.

./openwisp_ipam/static/openwisp-ipam/js/subnet.js is OK.

Running checks for openwisp_ipam
./openwisp_ipam/templates/admin/openwisp-ipam/subnet/change_form.html needs newline at the end
ERROR: Blank endline check failed!
SUCCESS: Migration name check on "./openwisp_ipam/migrations/" with migrations-to-ignore: 0 successful!
Skipped 1 files
SUCCESS: Isort check successful!
All done! ✨ 🍰 ✨
53 files would be left unchanged.
SUCCESS: Black check successful!
SUCCESS: Flake8 check successful!
SUCCESS: Commit message check successful!
No changes detected in app 'openwisp_ipam'
SUCCESS: Migrations check successful!

TravisBuddy Request Identifier: 827707a0-200b-11eb-9dab-419bf2960c30

[atb00ker]

No bugs decided to show themselves while testing! 😄
Thanks @purhan ,
LGTM! 👍

[nemesifier]

Thanks @purhan, testing some improvements to this in #72, please see my changes there, will merge after build is successful.

Please take a look at #71 and #73 which are some issues I found during testing this feature.